Re: [PATCH] mergetools/meld: improve backwards-compatibiilty when using "--output"

From: David Aguilar <davvid@gmail.com>
Date: Jun 18, 2017, 07:46 UTC
Message-ID: <20170618074603.epf3vhsi4pevg6jn@gmail.com>
In-Reply-To: <CAJZjrdX=8DbRTsdJ+bH5BABJG0m=y2QpT8C4kFviUsxVqVLVLg@mail.gmail.com>

On Sat, Jun 17, 2017 at 10:11:36AM -0400, Samuel Lijin wrote:

Show 7 quoted lines

> On Sat, Jun 17, 2017 at 6:24 AM, David Aguilar <davvid@gmail.com> wrote:
> > Meld 3.16.0 requires a "=" in the --output argument, as it uses
> > a simple hand-rolled command-line parser.
> >
> > Newer versions of Meld (3.16.4, and possibly earlier) use
> > optpaarse, which accepts either "--output <file>" or
> > "--output=<file>".

Junio, there's an optpaarse -> optparse typo in the commit message here in case you want to fix that up.

> 
> Do older versions also support both?

No. When the "--output" option was first added (3.16.0, or possibly earlier) it used the simpler parser that does not undertand the "--output <filename>" form.

Much older versions didn't support "--output" at all, so we don't have to worry about them since we already use the "--output" flag selectively based on whether or not it's supported.

-- 
David