Re: [RFC/PATCH 0/5] remote: eliminate remote->{fetch,push}_refspec and lazy parsing of refspecs

From: Jeff King <peff@peff.net>
Date: Jun 17, 2017, 12:33 UTC
Message-ID: <20170617123354.xolqjqdvofjtksll@sigill.intra.peff.net>
In-Reply-To: <CAM0VKj=1DiPZzGot34Ar9SQR8VWV8ugvzFhAMibnZ8d-4F+1QA@mail.gmail.com>

On Sat, Jun 17, 2017 at 02:25:39PM +0200, SZEDER Gábor wrote:

Show 7 quoted lines

> >>   - The same information is stored twice, wasting memory.
> >
> > True (but a few hundred bytes is nothing among friends ;-)
> 
> Indeed.  Even in my repos with close to 10k remotes the amount of
> memory wasted by the duplicated refspecs is not an problem, there are
> more pressing issues there.

This is sort of a side note, but I'm curious why you need 10k remotes.

We used to do this at GitHub as part of our fork storage (the shared repository had each fork as a remote). We fixed the quadratic issues like d0da003d5 (use a hashmap to make remotes faster, 2014-07-29). But even the linear work to read the config is noticeable (and hits you on every command, even ones that don't care about remotes). Now instead we pass the refspecs directly to fetch whenever move objects between the storage repos. They were the same for every remote anyway (and I'd guess that is true, too, of your 10k remotes).

-Peff