git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] stash: update documentation to use 'stash entries'

From
Jeff King <peff@peff.net>
Date
Jun 16, 2017, 12:06 UTC
Message-ID
<20170616120607.dj474det3dbx6ang@sigill.intra.peff.net>
In-Reply-To
<20170616043050.29192-2-liambeguin@gmail.com>
On Fri, Jun 16, 2017 at 12:30:48AM -0400, Liam Beguin wrote:
> Most of the time, a 'stash entry' is called a 'stash'
> or a 'stash state'. Lets use 'stash entry' instead.
I agree that this reads better. There is one exception:
Show 11 quoted lines
> diff --git a/git-stash.sh b/git-stash.sh
> index 2fb651b2b8d9..0dfa4785f361 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -481,7 +481,7 @@ parse_flags_and_rev()
>  
>  	case $# in
>  		0)
> -			have_stash || die "$(gettext "No stash found.")"
> +			have_stash || die "$(gettext "No stash entry found.")"
>  			set -- ${ref_stash}@{0}

I don't think your change is wrong (and it's probably more grammatical than the original), but should this perhaps be "No stashes found" or "No stash entries found"?

-Peff
Previous: Liam BeguinNext: Junio C Hamano
Message 3 of 16 in “add stash count information to git-status command”
  1. 0/3 add stash count information to git-status commandLiam Beguin, Jun 16, 2017
  2. 1/3 stash: update documentation to use 'stash entries'Liam Beguin, Jun 16, 2017
  3. Jeff KingJun 16, 2017
  4. Junio C HamanoJun 16, 2017
  5. 2/3 wt-status: add optional stash status informationLiam Beguin, Jun 16, 2017
  6. Jeff KingJun 16, 2017
  7. Junio C HamanoJun 16, 2017
  8. 3/3 glossary: define stash entriesLiam Beguin, Jun 16, 2017
  9. Jeff KingJun 16, 2017
  10. Jeff KingJun 16, 2017
  11. Liam BeguinJun 16, 2017
  12. 0/3 add stash count information to git-status commandLiam Beguin, Jun 17, 2017
  13. 3/3 glossary: define 'stash entry'Liam Beguin, Jun 17, 2017
  14. 1/3 stash: update documentation to use 'stash entry'Liam Beguin, Jun 17, 2017
  15. 2/3 status: add optional stash count informationLiam Beguin, Jun 17, 2017
  16. Junio C HamanoJun 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.