git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 0/6] Avoid problem where git_dir is set after alias expansion

From
Jeff King <peff@peff.net>
Date
Jun 15, 2017, 06:37 UTC
Message-ID
<20170615063739.xpja3bayrmiogbcz@sigill.intra.peff.net>
In-Reply-To
<cover.1497440104.git.johannes.schindelin@gmx.de>
On Wed, Jun 14, 2017 at 01:35:22PM +0200, Johannes Schindelin wrote:
Show 7 quoted lines
> Changes since v3:
> 
> - avoided the strbuf in alias_lookup() by using skip_prefix() and !strcmp()
>   instead.
> 
> - fixed tyop ("read" instead of "reading", causing Junio to stumble) in the
>   commit message of 6/6.

Thanks, this whole series looks good to me (and it sounds like Brandon will address the common-dir thing on top).

-Peff
Previous: Johannes Schindelin
Message 10 of 10 in “Avoid problem where git_dir is set after alias expansion”
  1. 0/6 Avoid problem where git_dir is set after alias expansionJohannes Schindelin, Jun 14, 2017
  2. 1/6 discover_git_directory(): avoid setting invalid git_dirJohannes Schindelin, Jun 14, 2017
  3. 3/6 help: use early config when autocorrecting aliasesJohannes Schindelin, Jun 14, 2017
  4. 4/6 t1308: relax the test verifying that empty alias values are disallowedJohannes Schindelin, Jun 14, 2017
  5. 2/6 config: report correct line number upon errorJohannes Schindelin, Jun 14, 2017
  6. 5/6 t7006: demonstrate a problem with aliases in subdirectoriesJohannes Schindelin, Jun 14, 2017
  7. 6/6 Use the early config machinery to expand aliasesJohannes Schindelin, Jun 14, 2017
  8. Junio C HamanoJun 15, 2017
  9. Johannes SchindelinJun 15, 2017
  10. Jeff KingJun 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.