git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 08/17] ls-files: convert write_eolinfo to take an index

From
BWBrandon Williams <bmwill@google.com>
Date
Jun 12, 2017, 22:13 UTC
Message-ID
<20170612221408.173876-9-bmwill@google.com>
In-Reply-To
<20170612221408.173876-1-bmwill@google.com>
Signed-off-by: Brandon Williams <bmwill@google.com>
---
 builtin/ls-files.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/builtin/ls-files.c b/builtin/ls-files.c
index a78b291ab..8c3f3d8ca 100644
--- a/builtin/ls-files.c
+++ b/builtin/ls-files.c
@@ -53,17 +53,16 @@ static const char *tag_modified = "";
 static const char *tag_skip_worktree = "";
 static const char *tag_resolve_undo = "";
 
-static void write_eolinfo(const struct cache_entry *ce, const char *path)
+static void write_eolinfo(const struct index_state *istate,
+			  const struct cache_entry *ce, const char *path)
 {
-	if (!show_eol)
-		return;
-	else {
+	if (show_eol) {
 		struct stat st;
 		const char *i_txt = "";
 		const char *w_txt = "";
 		const char *a_txt = get_convert_attr_ascii(path);
 		if (ce && S_ISREG(ce->ce_mode))
-			i_txt = get_cached_convert_stats_ascii(&the_index,
+			i_txt = get_cached_convert_stats_ascii(istate,
 							       ce->name);
 		if (!lstat(path, &st) && S_ISREG(st.st_mode))
 			w_txt = get_wt_convert_stats_ascii(path);
@@ -105,7 +104,7 @@ static void show_dir_entry(const char *tag, struct dir_entry *ent)
 		return;
 
 	fputs(tag, stdout);
-	write_eolinfo(NULL, ent->name);
+	write_eolinfo(NULL, NULL, ent->name);
 	write_name(ent->name);
 }
 
@@ -275,7 +274,7 @@ static void show_ce_entry(const char *tag, const struct cache_entry *ce)
 			       find_unique_abbrev(ce->oid.hash, abbrev),
 			       ce_stage(ce));
 		}
-		write_eolinfo(ce, ce->name);
+		write_eolinfo(&the_index, ce, ce->name);
 		write_name(ce->name);
 		if (debug_mode) {
 			const struct stat_data *sd = &ce->ce_stat_data;
-- 
2.13.1.518.g3df882009-goog
Previous: Brandon WilliamsNext: Brandon Williams
Message 16 of 18 in “convert ls-files internals to pass around an index”
  1. 00/17 convert ls-files internals to pass around an indexBrandon Williams, Jun 12, 2017
  2. 01/17 convert: convert get_cached_convert_stats_ascii to take an indexBrandon Williams, Jun 12, 2017
  3. 02/17 convert: convert crlf_to_git to take an indexBrandon Williams, Jun 12, 2017
  4. 03/17 convert: convert convert_to_git_filter_fd to take an indexBrandon Williams, Jun 12, 2017
  5. 04/17 convert: convert convert_to_git to take an indexBrandon Williams, Jun 12, 2017
  6. 07/17 ls-files: convert overlay_tree_on_cache to take an indexBrandon Williams, Jun 12, 2017
  7. 14/17 ls-files: convert show_ce_entry to take an indexBrandon Williams, Jun 12, 2017
  8. 13/17 ls-files: convert prune_cache to take an indexBrandon Williams, Jun 12, 2017
  9. 17/17 ls-files: factor out tag calculationBrandon Williams, Jun 12, 2017
  10. 12/17 ls-files: convert ce_excluded to take an indexBrandon Williams, Jun 12, 2017
  11. 15/17 ls-files: convert show_files to take an indexBrandon Williams, Jun 12, 2017
  12. 09/17 ls-files: convert show_killed_files to take an indexBrandon Williams, Jun 12, 2017
  13. 16/17 ls-files: factor out debug info into a functionBrandon Williams, Jun 12, 2017
  14. 10/17 ls-files: convert show_other_files to take an indexBrandon Williams, Jun 12, 2017
  15. 05/17 convert: convert renormalize_buffer to take an indexBrandon Williams, Jun 12, 2017
  16. 08/17 ls-files: convert write_eolinfo to take an indexBrandon Williams, Jun 12, 2017
  17. 06/17 tree: convert read_tree to take an index parameterBrandon Williams, Jun 12, 2017
  18. 11/17 ls-files: convert show_ru_info to take an indexBrandon Williams, Jun 12, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.