git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] fast-import: Increase the default pack depth to 50

From
Mike Hommey <mh@glandium.org>
Date
Jun 8, 2017, 05:34 UTC
Message-ID
<20170608053436.9121-1-mh@glandium.org>

In 618e613a70, 10 years ago, the default for pack depth used for git-pack-objects and git-repack was changed from 10 to 50, while leaving fast-import's default to 10.

There doesn't seem to be a reason besides oversight for the change not having happened in fast-import as well.

Interestingly, fast-import uses pack.depth when it's set, and the git-config manual says the default for pack.depth is 50. While the git-fast-import manual does say the default depth is 10, the inconsistency is also confusing.

Signed-off-by: Mike Hommey <mh@glandium.org>
---
 Documentation/git-fast-import.txt | 2 +-
 fast-import.c                     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
index 2b762654bf..3d3d219e58 100644
--- a/Documentation/git-fast-import.txt
+++ b/Documentation/git-fast-import.txt
@@ -121,7 +121,7 @@ Performance and Compression Tuning
 
 --depth=<n>::
 	Maximum delta depth, for blob and tree deltification.
-	Default is 10.
+	Default is 50.
 
 --export-pack-edges=<file>::
 	After creating a packfile, print a line of data to
diff --git a/fast-import.c b/fast-import.c
index e69d219682..05c73858b0 100644
--- a/fast-import.c
+++ b/fast-import.c
@@ -280,7 +280,7 @@ struct recent_command {
 };
 
 /* Configured limits on output */
-static unsigned long max_depth = 10;
+static unsigned long max_depth = 50;
 static off_t max_packsize;
 static int unpack_limit = 100;
 static int force_update;
-- 
2.13.0
Next: Jeff King
Message 1 of 4 in “fast-import: Increase the default pack depth to 50”
  1. fast-import: Increase the default pack depth to 50Mike Hommey, Jun 8, 2017
  2. Jeff KingJun 8, 2017
  3. Mike HommeyJun 8, 2017
  4. Jeff KingJun 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.