git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 00/13] reporting unexpected errors after (f)open

From
Junio C Hamano <gitster@pobox.com>
Date
May 26, 2017, 03:34 UTC
Message-ID
<20170526033510.1793-1-gitster@pobox.com>
In-Reply-To
<CACsJy8CzgHc=qe5w=FGJJ=ZU0a+JiqBrjWHV7SH3rAPKmOOKoA@mail.gmail.com>

These are taken from https://github.com/pclouds/git/commits/fopen-or-warn cf. <CACsJy8CzgHc=qe5w=FGJJ=ZU0a+JiqBrjWHV7SH3rAPKmOOKoA@mail.gmail.com> with a few bits salvaged from its v2 version.

Ramsay Jones (1):
  git_fopen: fix a sparse 'not declared' warning
Nguyễn Thái Ngọc Duy (9):
  use xfopen() in more places
  clone: use xfopen() instead of fopen()
  config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and FreeBSD
  wrapper.c: add and use warn_on_fopen_errors()
  wrapper.c: add and use fopen_or_warn()
  wrapper.c: make warn_on_inaccessible() static
  print errno when reporting a system call error
  rerere.c: move error_errno() closer to the source system call
  log: fix memory leak in open_next_file()
Junio C Hamano (3):
  config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, too
  wrapper: factor out is_missing_file_error()
  is_missing_file_error(): work around EINVAL on Windows

Patches 12 & 13 are my attempt to answer the issue the series had on Windows. cf. <xmqq37bseddy.fsf@gitster.mtv.corp.google.com>

 attr.c                |  7 ++-----
 bisect.c              |  7 ++-----
 builtin/am.c          |  8 ++------
 builtin/blame.c       |  2 +-
 builtin/clone.c       |  2 +-
 builtin/commit.c      |  5 +----
 builtin/fast-export.c |  4 +---
 builtin/fsck.c        |  3 +--
 builtin/log.c         | 11 ++++++++---
 builtin/merge.c       |  4 +---
 builtin/pull.c        |  3 +--
 commit.c              |  2 +-
 compat/fopen.c        |  4 ++--
 config.c              |  5 ++++-
 config.mak.uname      |  4 ++++
 diff.c                |  8 ++------
 dir.c                 |  6 +++---
 fast-import.c         |  4 +---
 git-compat-util.h     | 15 +++++++++------
 ident.c               |  8 +++-----
 remote-testsvn.c      |  8 ++------
 remote.c              |  4 ++--
 rerere.c              |  7 ++++---
 sequencer.c           |  8 ++++----
 server-info.c         |  2 +-
 t/t1308-config-set.sh | 13 ++++++++++++-
 t/t5512-ls-remote.sh  | 13 ++++++++++---
 wrapper.c             | 49 ++++++++++++++++++++++++++++++++++++++++++++-----
 wt-status.c           |  3 ++-
 xdiff-interface.c     |  4 ++--
 30 files changed, 133 insertions(+), 90 deletions(-)
-- 
2.13.0-491-g71cfeddc25
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 41 in “What's cooking in git.git (May 2017, #06; Mon, 22)”
  1. Junio C HamanoMay 22, 2017
  2. Jonathan NiederMay 22, 2017
  3. Junio C HamanoMay 23, 2017
  4. Jonathan NiederMay 23, 2017
  5. Junio C HamanoMay 23, 2017
  6. Duy NguyenMay 25, 2017
  7. Junio C HamanoMay 26, 2017
  8. 00/13 reporting unexpected errors after (f)openJunio C Hamano, May 26, 2017
  9. 01/13 git_fopen: fix a sparse 'not declared' warningJunio C Hamano, May 26, 2017
  10. 02/13 use xfopen() in more placesJunio C Hamano, May 26, 2017
  11. 03/13 clone: use xfopen() instead of fopen()Junio C Hamano, May 26, 2017
  12. 05/13 config.mak.uname: set FREAD_READS_DIRECTORIES for Darwin, tooJunio C Hamano, May 26, 2017
  13. Stefan BellerMay 30, 2017
  14. Junio C HamanoMay 30, 2017
  15. Stefan BellerMay 30, 2017
  16. 04/13 config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and FreeBSDJunio C Hamano, May 26, 2017
  17. 06/13 wrapper.c: add and use warn_on_fopen_errors()Junio C Hamano, May 26, 2017
  18. 07/13 wrapper.c: add and use fopen_or_warn()Junio C Hamano, May 26, 2017
  19. 09/13 print errno when reporting a system call errorJunio C Hamano, May 26, 2017
  20. 10/13 rerere.c: move error_errno() closer to the source system callJunio C Hamano, May 26, 2017
  21. Stefan BellerMay 30, 2017
  22. 08/13 wrapper.c: make warn_on_inaccessible() staticJunio C Hamano, May 26, 2017
  23. 11/13 log: fix memory leak in open_next_file()Junio C Hamano, May 26, 2017
  24. 12/13 wrapper: factor out is_missing_file_error()Junio C Hamano, May 26, 2017
  25. 1/2 compat-util: is_missing_file_error()Junio C Hamano, May 30, 2017
  26. 2/2 treewide: use is_missing_file_error() where ENOENT and ENOTDIR are checkedJunio C Hamano, May 30, 2017
  27. 13/13 is_missing_file_error(): work around EINVAL on WindowsJunio C Hamano, May 26, 2017
  28. 1/2 mingw: verify that paths are not mistaken for remote nicknamesJohannes Sixt, May 29, 2017
  29. 2/2 mingw_fopen: report ENOENT for invalid file namesJohannes Sixt, May 29, 2017
  30. Ævar Arnfjörð BjarmasonMay 29, 2017
  31. Johannes SixtMay 29, 2017
  32. Ramsay JonesMay 29, 2017
  33. Junio C HamanoMay 30, 2017
  34. Ramsay JonesMay 30, 2017
  35. Junio C HamanoMay 29, 2017
  36. Junio C HamanoMay 30, 2017
  37. Johannes SixtMay 30, 2017
  38. Junio C HamanoMay 30, 2017
  39. Stefan BellerMay 30, 2017
  40. Junio C HamanoMay 30, 2017
  41. Stefan BellerMay 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.