git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 15/29] blame: move xdl_opts flags to scoreboard

From
Jeff Smith <whydoubt@gmail.com>
Date
May 24, 2017, 05:15 UTC
Message-ID
<20170524051537.29978-16-whydoubt@gmail.com>
In-Reply-To
<20170524051537.29978-1-whydoubt@gmail.com>

The xdl_opts flags are used in parts of blame that are being moved to libgit, and should be accessible via the scoreboard structure.

Signed-off-by: Jeff Smith <whydoubt@gmail.com>
---
 builtin/blame.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index fdd41b4..8e676fb 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -125,7 +125,7 @@ struct progress_info {
 };
 
 static int diff_hunks(mmfile_t *file_a, mmfile_t *file_b,
-		      xdl_emit_hunk_consume_func_t hunk_func, void *cb_data)
+		      xdl_emit_hunk_consume_func_t hunk_func, void *cb_data, int xdl_opts)
 {
 	xpparam_t xpp = {0};
 	xdemitconf_t xecfg = {0};
@@ -385,6 +385,7 @@ struct blame_scoreboard {
 	/* flags */
 	int reverse;
 	int show_root;
+	int xdl_opts;
 };
 
 static void sanity_check_refcnt(struct blame_scoreboard *);
@@ -948,7 +949,7 @@ static void pass_blame_to_parent(struct blame_scoreboard *sb,
 	fill_origin_blob(&sb->revs->diffopt, target, &file_o, &sb->num_read_blob);
 	sb->num_get_patch++;
 
-	if (diff_hunks(&file_p, &file_o, blame_chunk_cb, &d))
+	if (diff_hunks(&file_p, &file_o, blame_chunk_cb, &d, sb->xdl_opts))
 		die("unable to generate diff (%s -> %s)",
 		    oid_to_hex(&parent->commit->object.oid),
 		    oid_to_hex(&target->commit->object.oid));
@@ -1097,7 +1098,7 @@ static void find_copy_in_blob(struct blame_scoreboard *sb,
 	 * file_p partially may match that image.
 	 */
 	memset(split, 0, sizeof(struct blame_entry [3]));
-	if (diff_hunks(file_p, &file_o, handle_split_cb, &d))
+	if (diff_hunks(file_p, &file_o, handle_split_cb, &d, sb->xdl_opts))
 		die("unable to generate diff (%s)",
 		    oid_to_hex(&parent->commit->object.oid));
 	/* remainder, if any, all match the preimage */
@@ -2887,6 +2888,7 @@ int cmd_blame(int argc, const char **argv, const char *prefix)
 		sb.copy_score = blame_copy_score;
 
 	sb.show_root = show_root;
+	sb.xdl_opts = xdl_opts;
 
 	read_mailmap(&mailmap, NULL);
 
-- 
2.9.3
Previous: Junio C HamanoNext: Jeff Smith
Message 36 of 39 in “Add blame to libgit”
  1. 00/29 Add blame to libgitJeff Smith, May 24, 2017
  2. 01/29 blame: remove unneeded dependency on blob.hJeff Smith, May 24, 2017
  3. 03/29 blame: remove unused parametersJeff Smith, May 24, 2017
  4. 02/29 blame: move textconv_object with related functionsJeff Smith, May 24, 2017
  5. 04/29 blame: rename origin structure to blame_originJeff Smith, May 24, 2017
  6. 05/29 blame: rename scoreboard structure to blame_scoreboardJeff Smith, May 24, 2017
  7. 06/29 blame: rename origin-related functionsJeff Smith, May 24, 2017
  8. 10/29 blame: move stat counters to scoreboardJeff Smith, May 24, 2017
  9. 11/29 blame: move copy/move thresholds to scoreboardJeff Smith, May 24, 2017
  10. 14/29 blame: move show_root flag to scoreboardJeff Smith, May 24, 2017
  11. 13/29 blame: move reverse flag to scoreboardJeff Smith, May 24, 2017
  12. 12/29 blame: move contents_from to scoreboardJeff Smith, May 24, 2017
  13. 09/29 blame: rename nth_line functionJeff Smith, May 24, 2017
  14. 19/29 blame: wrap blame_sort and compare_blame_finalJeff Smith, May 24, 2017
  15. 16/29 blame: move no_whole_file_rename flag to scoreboardJeff Smith, May 24, 2017
  16. 07/29 blame: rename coalesce functionJeff Smith, May 24, 2017
  17. 23/29 blame: create entry prepend functionJeff Smith, May 24, 2017
  18. Junio C HamanoMay 25, 2017
  19. 24/29 blame: move core structures to headerJeff Smith, May 24, 2017
  20. Junio C HamanoMay 25, 2017
  21. 21/29 blame: create scoreboard init functionJeff Smith, May 24, 2017
  22. 26/29 blame: move fake-commit-related methods to libgitJeff Smith, May 24, 2017
  23. 22/29 blame: create scoreboard setup functionJeff Smith, May 24, 2017
  24. Junio C HamanoMay 25, 2017
  25. 27/29 blame: move scoreboard-related methods to libgitJeff Smith, May 24, 2017
  26. 25/29 blame: move origin-related methods to libgitJeff Smith, May 24, 2017
  27. 28/29 blame: move scoreboard setup to libgitJeff Smith, May 24, 2017
  28. Junio C HamanoMay 25, 2017
  29. Jeffrey SmithMay 25, 2017
  30. 18/29 blame: move progess updates to a scoreboard callbackJeff Smith, May 24, 2017
  31. Junio C HamanoMay 25, 2017
  32. 17/29 blame: make sanity_check use a callback in scoreboardJeff Smith, May 24, 2017
  33. 29/29 blame: move entry prepend to libgitJeff Smith, May 24, 2017
  34. 20/29 blame: rework methods that determine 'final' commitJeff Smith, May 24, 2017
  35. Junio C HamanoMay 25, 2017
  36. 15/29 blame: move xdl_opts flags to scoreboardJeff Smith, May 24, 2017
  37. 08/29 blame: rename ent_score functionJeff Smith, May 24, 2017
  38. Junio C HamanoMay 24, 2017
  39. Junio C HamanoMay 25, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.