Re: reversion in GIT_COMMON_DIR refs path

From: Joey Hess <id@joeyh.name>
Date: May 19, 2017, 14:37 UTC
Message-ID: <20170519143727.edi4ni7v5pywm7dk@kitenet.net>
In-Reply-To: <20170516171028.5eagqr2sw5a2i77d@kitenet.net>

Joey Hess wrote:

Show 7 quoted lines

> Bisecting this test suite failure
> https://git-annex.branchable.com/git-annex_in_nixpkgs_fails_with_git-2.13.0/
> I landed on commit f57f37e2e1bf11ab4cdfd221ad47e961ba9353a0 to git.
> 
> It seems that changed resolving refs paths when GIT_DIR and GIT_COMMON_DIR
> are both set. While before refs were looked for in GIT_COMMON_DIR,
> now they're not.

In case there's any doubt about whether this is a reversion or an intentional change, see gitrepository-layout(5):

       refs
           References are stored in subdirectories of this directory. The git
           prune command knows to preserve objects reachable from refs found
           in this directory and its subdirectories. This directory is ignored
           if $GIT_COMMON_DIR is set and "$GIT_COMMON_DIR/refs" will be used
           instead.

So the documented behavior is broken.

-- 
see shy jo