Re: [PATCH v1 2/5] Teach git to optionally utilize a file system monitor to speed up detecting new or changed files.

From: Jeff King <peff@peff.net>
Date: May 16, 2017, 02:51 UTC
Message-ID: <20170516025120.xn5dimkuryl33wfk@sigill.intra.peff.net>
In-Reply-To: <2d965a87-36da-23b4-4bc5-97de47f3d7f7@gmail.com>

On Mon, May 15, 2017 at 09:55:12PM -0400, Ben Peart wrote:

Show 9 quoted lines

> > > > +	istate->last_update = (time_t)ntohll(*(uint64_t *)index);
> [...]
> > (I note also that time_t is not necessarily 64-bits in the first place,
> > but David said something about this not really being a time_t).
> 
> The in memory representation is a time_t as that is the return value of
> time(NULL) but it is converted to/from a 64 bit value when written/read to
> the index extension so that the index format is the same no matter the
> native size of time_t.

OK. I guess your cast here will truncate on 32-bit systems, but presumably not until 2038, so we can perhaps ignore it for now (and anyway, time(NULL) will be broken on such a system at that point).

-Peff