Re: [PATCH 1/7] compat/regex: add a README with a maintenance guide
- From
- arnold@skeeve.com <arnold@skeeve.com>
- Date
- May 14, 2017, 19:14 UTC
- Message-ID
- <201705141914.v4EJETGf029570@freefriends.org>
- In-Reply-To
- <xmqqbmqx6bbh.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
Show 11 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > - rather than scraping the files from the CGit website (which does not > > guarantee that the first scraped file will be from the same revision as > > the last scraped file), I would very strongly prefer the files to be > > copied from a clone of gawk.git, and the gawk.git revision from which > > they were copied should be recorded in git.git's commit adding them. > > Wow, I didn't even notice that was how the "original" came about. > No question that we should be taking from a known-stable snapshot, > not from a moving target.
Gawk's regex has been fairly stable of late. But marking the revision from which you take the regex is a good idea in any case.
With respect to bug fixes that may have happened downstream, please do let me know of any. But I do request it as a bug report to bug-gawk@gnu.org and not just a pull request with no commentary.
Thanks,
Arnold