git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] usage.c: drop set_error_handle()

From
BWBrandon Williams <bmwill@google.com>
Date
May 14, 2017, 02:12 UTC
Message-ID
<20170514021215.GA82343@google.com>
In-Reply-To
<20170513034818.h3aaihqmf4q43vef@sigill.intra.peff.net>
On 05/12, Jeff King wrote:
Show 12 quoted lines
> The set_error_handle() function was introduced by 3b331e926
> (vreportf: report to arbitrary filehandles, 2015-08-11) so
> that run-command could send post-fork, pre-exec errors to
> the parent's original stderr.
> 
> That use went away in 79319b194 (run-command: eliminate
> calls to error handling functions in child, 2017-04-19),
> which pushes all of the error reporting to the parent.
> This leaves no callers of set_error_handle(). As we're not
> likely to add any new ones, let's drop it.
> 
> Signed-off-by: Jeff King <peff@peff.net>
Looks good to me!
Thanks
-- 
Brandon Williams
Previous: Ramsay Jones
Message 3 of 3 in “usage.c: drop set_error_handle()”
  1. usage.c: drop set_error_handle()Jeff King, May 13, 2017
  2. Ramsay JonesMay 13, 2017
  3. Brandon WilliamsMay 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.