git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 00/10] refactor the filter process code into a reusable module

From
Jeff King <peff@peff.net>
Date
May 13, 2017, 09:16 UTC
Message-ID
<20170513091637.zebzyi7ggidybzak@sigill.intra.peff.net>
In-Reply-To
<xmqqfuggaz3d.fsf@gitster.mtv.corp.google.com>
On Mon, May 08, 2017 at 10:58:46AM +0900, Junio C Hamano wrote:
> Will queue; during the pre-release freeze, new things would move
> slowly, but let's see if we have more comments from others and then
> merge it to 'next' soon after the 2.13 final.

I gave it a fresh read-through. I had a few comments, but nothing that I think should hold up moving these patches to 'next'.

I do find the convert/sub-process split a little funny. Most of the protocol bits from convert didn't get moved over, and you could use a sub-process that spoke any arbitrary protocol. The odd man out is subprocess_read_status(), which assumes not only pktlines, but also a "status=foo" key/value pair inside them.

I have a feeling that funny split is because this is a preliminary refactoring step that will have more features built on it, and the end result may be more consistent. We _could_ hold these back and pass judgement once we see more. But they're a reasonable-sized chunk that's already been through 7 rounds of review. It makes sense to me to graduate them at least to 'next' and let the next steps use them as a stable base.

-Peff
Previous: Junio C Hamano
Message 16 of 16 in “refactor the filter process code into a reusable module”
  1. 00/10 refactor the filter process code into a reusable moduleBen Peart, May 5, 2017
  2. 01/10 convert: remove erroneous tests for errno == EPIPEBen Peart, May 5, 2017
  3. 02/10 pkt-line: fix packet_read_line() to handle len < 0 errorsBen Peart, May 5, 2017
  4. 03/10 pkt-line: add packet_read_line_gently()Ben Peart, May 5, 2017
  5. 04/10 convert: move packet_write_line() into pkt-line as packet_writel()Ben Peart, May 5, 2017
  6. Jeff KingMay 13, 2017
  7. Junio C HamanoMay 15, 2017
  8. 05/10 convert: split start_multi_file_filter() into two separate functionsBen Peart, May 5, 2017
  9. 07/10 convert: Update generic functions to only use generic data structuresBen Peart, May 5, 2017
  10. 09/10 sub-process: move sub-process functions into separate filesBen Peart, May 5, 2017
  11. Jeff KingMay 13, 2017
  12. 10/10 convert: Update subprocess_read_status to not die on EOFBen Peart, May 5, 2017
  13. 08/10 convert: rename reusable sub-process functionsBen Peart, May 5, 2017
  14. 06/10 convert: Separate generic structures and variables from the filter specific onesBen Peart, May 5, 2017
  15. Junio C HamanoMay 8, 2017
  16. Jeff KingMay 13, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.