git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/7] grep: don't redundantly compile throwaway patterns under threading

From
BWBrandon Williams <bmwill@google.com>
Date
May 12, 2017, 17:35 UTC
Message-ID
<20170512173527.GD98586@google.com>
In-Reply-To
<20170511170142.15934-2-avarab@gmail.com>
On 05/11, Ævar Arnfjörð Bjarmason wrote:
> Change the pattern compilation logic under threading so that grep
> doesn't compile a pattern it never ends up using on the non-threaded
> code path, only to compile it again N times for N threads which will
> each use their own copy, ignoring the initially compiled pattern.

Is there a reason each thread needs to compile the patterns as opposed to them being compiled a single time and being copies N time for N threads?

-- 
Brandon Williams
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 3 of 10 in “PCRE v2, PCRE v1 JIT, log -P & fixes”
  1. 0/7 PCRE v2, PCRE v1 JIT, log -P & fixesÆvar Arnfjörð Bjarmason, May 11, 2017
  2. 1/7 grep: don't redundantly compile throwaway patterns under threadingÆvar Arnfjörð Bjarmason, May 11, 2017
  3. Brandon WilliamsMay 12, 2017
  4. Ævar Arnfjörð BjarmasonMay 12, 2017
  5. 2/7 grep: skip pthreads overhead when using one threadÆvar Arnfjörð Bjarmason, May 11, 2017
  6. 3/7 log: add -P as a synonym for --perl-regexpÆvar Arnfjörð Bjarmason, May 11, 2017
  7. 4/7 grep: add support for the PCRE v1 JIT APIÆvar Arnfjörð Bjarmason, May 11, 2017
  8. 5/7 grep: un-break building with PCRE < 8.32Ævar Arnfjörð Bjarmason, May 11, 2017
  9. 6/7 grep: un-break building with PCRE < 8.20Ævar Arnfjörð Bjarmason, May 11, 2017
  10. 7/7 grep: add support for PCRE v2Ævar Arnfjörð Bjarmason, May 11, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.