Re: [PATCH] pack-objects: disable pack reuse for object-selection options

From: Jeff King <peff@peff.net>
Date: May 9, 2017, 02:21 UTC
Message-ID: <20170509022114.s3tpxrgtplsopr4x@sigill.intra.peff.net>
In-Reply-To: <xmqqfuge6akl.fsf@gitster.mtv.corp.google.com>

On Tue, May 09, 2017 at 11:14:18AM +0900, Junio C Hamano wrote:

Show 14 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> >> Ah, OK, and now I understand why you called this a "bug" (which is
> >> older and do not need to be addressed as part of 2.13) in the
> >> original message.  The new tests check requests that ought to
> >> produce an empty packfile as the result actually do, but with the
> >> current code, the reuse code does not work with --local and friends
> >> and ends up including what was requested to be excluded.
> >
> > Right. Did you want me to try re-wording the commit message, or does it
> > make sense now?
> 
> It does make sense to me now, but I do not speak for all future
> readers of "git log", so...

I guess what I was asking was: do you still think it was unclear, or do you think you were just being dense?

I don't feel like I gave any information in the follow-on explanation that wasn't in the commit message, so I wasn't clear if I worded it better or if it just sunk in better.

-Peff