Re: [PATCH v1 2/2] travis-ci: add job to run tests with GETTEXT_POISON

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 5, 2017, 16:08 UTC
Message-ID: <20170505160813.GH28740@aiede.svl.corp.google.com>
In-Reply-To: <20170505154053.58128-3-larsxschneider@gmail.com>

Hi,

Lars Schneider wrote:

Show 10 quoted lines

> Add a job to run Git tests with GETTEXT_POISON. In this job we don't run
> the git-p4, git-svn, and HTTPD tests to save resources/time (those tests
> are already executed in other jobs). Since we don't run these tests, we
> can also skip the "before_install" step (which would install the
> necessary dependencies) with an empty override.
>
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
>  .travis.yml | 5 +++++
>  1 file changed, 5 insertions(+)

Yay!  I like this.

What I like most about GETTEXT_POISON is that it verifies that translatable strings are not affecting other functionality of Git. It's a valuable thing to test continuously.

For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.