[PATCH v2 21/21] t1308: add a test case on open a config directory
- From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
- Date
- May 3, 2017, 10:17 UTC
- Message-ID
- <20170503101706.9223-22-pclouds@gmail.com>
- In-Reply-To
- <20170503101706.9223-1-pclouds@gmail.com>
We don't support config-as-a-directory (maybe someday we will?). Make sure we consistently fail in this case, which should happen on platforms where fopen(<directory>) returns non-NULL if FREAD_READS_DIRECTORIES is defined.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> --- t/t1308-config-set.sh | 9 +++++++++ 1 file changed, 9 insertions(+)
diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh index 13e95561f4..e495a61616 100755 --- a/t/t1308-config-set.sh +++ b/t/t1308-config-set.sh @@ -183,6 +183,15 @@ test_expect_success 'proper error on non-existent files' ' test_cmp expect actual ' +test_expect_success 'proper error on directory "files"' ' + echo "Error (-1) reading configuration file a-directory." >expect && + mkdir a-directory && + test_expect_code 2 test-config configset_get_value foo.bar a-directory 2>output && + grep "^warning:" output && + grep "^Error" output >actual && + test_cmp expect actual +' + test_expect_success POSIXPERM,SANITY 'proper error on non-accessible files' ' chmod -r .git/config && test_when_finished "chmod +r .git/config" &&
-- 2.11.0.157.gd943d85