Re: [PATCH 0/5] Abide by our own rules regarding line endings

From: Jonathan Nieder <jrnieder@gmail.com>
Date: May 2, 2017, 21:56 UTC
Message-ID: <20170502215627.GX28740@aiede.svl.corp.google.com>
In-Reply-To: <cover.1493728172.git.johannes.schindelin@gmx.de>

Hi,

Johannes Schindelin wrote:

> Over the past decade, there have been a couple of attempts to remedy the

[...]

I'm intentionally skimming this cover letter, since anything important it says needs to also be in the commit messages.

[...]

Show 6 quoted lines

> Without these fixes, Git will fail to build and pass the test suite, as
> can be verified even on Linux using this cadence:
>
> 	git config core.autocrlf true
> 	rm .git/index && git stash
> 	make DEVELOPER=1 -j15 test

This should go in a commit message (or perhaps in all of them).

[...]

Show 6 quoted lines

> Johannes Schindelin (5):
>   Fix build with core.autocrlf=true
>   git-new-workdir: mark script as LF-only
>   completion: mark bash script as LF-only
>   Fix the remaining tests that failed with core.autocrlf=true
>   t4051: mark supporting files as requiring LF-only line endings

With or without that change,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

The t/README bit in patch 4/5 is sad (I want to be able to open t/README using an old version of Notepad) but changing that test to use another file seems out of scope for what this series does.

Thanks, Jonathan