git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 3/4] travis-ci: check AsciiDoc/AsciiDoctor stderr output

From
Lars Schneider <larsxschneider@gmail.com>
Date
Apr 26, 2017, 19:15 UTC
Message-ID
<20170426191545.27552-4-larsxschneider@gmail.com>
In-Reply-To
<20170426191545.27552-1-larsxschneider@gmail.com>

`make` does not necessarily fail with an error code if Asciidoc/AsciiDoctor encounters problems. Anything written to stderr might be a better indicator for problems.

Ensure that nothing is written to stderr during a documentation build.

The redirects do not work in `sh`, therefore the script uses `bash`. This shouldn't be a problem as the script is only executed on TravisCI.

Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
---
 ci/test-documentation.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/ci/test-documentation.sh b/ci/test-documentation.sh
index 58962d668a..6214e6acb4 100755
--- a/ci/test-documentation.sh
+++ b/ci/test-documentation.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/env bash
 #
 # Perform sanity checks on documentation and build it.
 #
@@ -9,7 +9,8 @@ make check-builtins
 make check-docs
 
 # Build docs with AsciiDoc
-make --jobs=2 doc
+make --jobs=2 doc > >(tee stdout.log) 2> >(tee stderr.log >&2)
+! test -s stderr.log
 test -s Documentation/git.html
 test -s Documentation/git.xml
 test -s Documentation/git.1
@@ -17,6 +18,8 @@ grep '<meta name="generator" content="AsciiDoc ' Documentation/git.html
 
 # Build docs with AsciiDoctor
 make clean
-make --jobs=2 USE_ASCIIDOCTOR=1 doc
+make --jobs=2 USE_ASCIIDOCTOR=1 doc > >(tee stdout.log) 2> >(tee stderr.log >&2)
+sed '/^GIT_VERSION = / d' stderr.log
+! test -s stderr.log
 test -s Documentation/git.html
 grep '<meta name="generator" content="Asciidoctor ' Documentation/git.html
-- 
2.12.2
Previous: Lars SchneiderNext: Junio C Hamano
Message 4 of 6 in “travis-ci: build docs with asciidoctor”
  1. 0/4 travis-ci: build docs with asciidoctorLars Schneider, Apr 26, 2017
  2. 1/4 travis-ci: build documentation with AsciiDoc and AsciidoctorLars Schneider, Apr 26, 2017
  3. 2/4 travis-ci: parallelize documentation buildLars Schneider, Apr 26, 2017
  4. 3/4 travis-ci: check AsciiDoc/AsciiDoctor stderr outputLars Schneider, Apr 26, 2017
  5. Junio C HamanoApr 27, 2017
  6. 4/4 travis-ci: unset compiler for jobs that do not need oneLars Schneider, Apr 26, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.