Re: [PATCH] t/perf: correctly align non-ASCII descriptions in output
- From
Jeff King <peff@peff.net>
- Date
- Apr 21, 2017, 22:05 UTC
- Message-ID
- <20170421220500.7ovz3dqintcyfhb5@sigill.intra.peff.net>
- In-Reply-To
- <CACBZZX5ERL4ecLL9AvPVKZGXhAS+RQsSSBQEEK7w3yR86A_tMg@mail.gmail.com>
On Sat, Apr 22, 2017 at 12:02:02AM +0200, Ævar Arnfjörð Bjarmason wrote:
Show 10 quoted lines
> > Yeah, I know "use utf8" doesn't work for that, but I was thinking there > > was some other trick. Digging...ah, here it is: > > > > use open ':encoding(utf8)' > > > > No clue how portable that is. For such a small script it may be better > > to just stick with vanilla binmode(). > > Yeah that would work, but doesn't work on 5.8.0, which is the lowest > version we support.
Thanks for looking that up.
For the benefit of the maintainer, I'll summarize: Ævar's original patch is fine as-is.
-Peff