git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 06/13] grep & rev-list doc: stop promising libpcre for --perl-regexp

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Apr 19, 2017, 22:40 UTC
Message-ID
<20170419224053.8920-7-avarab@gmail.com>
In-Reply-To
<20170419224053.8920-1-avarab@gmail.com>

Stop promising in our grep & rev-list options documentation that we're always going to be using libpcre when given the --perl-regexp option.

Instead talk about using "Perl-compatible regular expressions" and using "the PCRE library". Saying "libpcre" strongly suggests that we might be talking about libpcre.so, which is always going to be v1.

Not only do does the documentation now align more clearly with future plans, but it should be more easily readable to the layman.

This is for preparation for libpcre2 support, which in the future may be powering the --perl-regexp option by default, depending on how Git is compiled.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Documentation/git-grep.txt         | 4 ++--
 Documentation/rev-list-options.txt | 5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-grep.txt b/Documentation/git-grep.txt
index 71f32f3508..e42ba83c42 100644
--- a/Documentation/git-grep.txt
+++ b/Documentation/git-grep.txt
@@ -161,8 +161,8 @@ OPTIONS
 
 -P::
 --perl-regexp::
-	Use Perl-compatible regexp for patterns. Requires libpcre to be
-	compiled in.
+	Use Perl-compatible regular expressions for patterns. Uses the
+	PCRE library, which Git needs to be compiled against.
 
 -F::
 --fixed-strings::
diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt
index 5b7fa49a7f..565cde636e 100644
--- a/Documentation/rev-list-options.txt
+++ b/Documentation/rev-list-options.txt
@@ -93,8 +93,9 @@ endif::git-rev-list[]
 
 -P::
 --perl-regexp::
-	Consider the limiting patterns to be Perl-compatible regular expressions.
-	Requires libpcre to be compiled in.
+	Consider the limiting patterns to be Perl-compatible regular
+	expressions. Uses the PCRE library, which Git needs to be
+	compiled against.
 
 --remove-empty::
 	Stop when a given path disappears from the tree.
-- 
2.11.0
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 7 of 14 in “PCRE v1 improvements & PCRE v2 support”
  1. 00/13 PCRE v1 improvements & PCRE v2 supportÆvar Arnfjörð Bjarmason, Apr 19, 2017
  2. 01/13 grep: remove redundant regflags assignment under PCREÆvar Arnfjörð Bjarmason, Apr 19, 2017
  3. 02/13 Makefile & configure: reword outdated comment about PCREÆvar Arnfjörð Bjarmason, Apr 19, 2017
  4. 03/13 grep: add a test for backreferences in PCRE patternsÆvar Arnfjörð Bjarmason, Apr 19, 2017
  5. 04/13 log: add exhaustive tests for pattern style options & configÆvar Arnfjörð Bjarmason, Apr 19, 2017
  6. 05/13 log: add -P as a synonym for --perl-regexpÆvar Arnfjörð Bjarmason, Apr 19, 2017
  7. 06/13 grep & rev-list doc: stop promising libpcre for --perl-regexpÆvar Arnfjörð Bjarmason, Apr 19, 2017
  8. 08/13 test-lib: rename the LIBPCRE prerequisite to PCREÆvar Arnfjörð Bjarmason, Apr 19, 2017
  9. 09/13 grep: change the internal PCRE macro names to be PCRE1Ævar Arnfjörð Bjarmason, Apr 19, 2017
  10. 07/13 grep: make grep.patternType=[pcre|pcre1] a synonym for "perl"Ævar Arnfjörð Bjarmason, Apr 19, 2017
  11. 10/13 grep: change the internal PCRE code & header names to be PCRE1Ævar Arnfjörð Bjarmason, Apr 19, 2017
  12. 11/13 perf: add a performance comparison test of grep -E and -PÆvar Arnfjörð Bjarmason, Apr 19, 2017
  13. 12/13 grep: add support for the PCRE v1 JIT APIÆvar Arnfjörð Bjarmason, Apr 19, 2017
  14. 13/13 grep: add support for PCRE v2Ævar Arnfjörð Bjarmason, Apr 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.