Re: [PATCH 11/12] grep: change the internal PCRE code & header names to be PCRE1

From: Jeff King <peff@peff.net>
Date: Apr 11, 2017, 10:37 UTC
Message-ID: <20170411103746.bth3rof753gbjtjf@sigill.intra.peff.net>
In-Reply-To: <20170408132506.5415-12-avarab@gmail.com>

On Sat, Apr 08, 2017 at 01:25:05PM +0000, Ævar Arnfjörð Bjarmason wrote:

Show 12 quoted lines

> diff --git a/builtin/grep.c b/builtin/grep.c
> index 9478ab5dff..dffb9743b8 100644
> --- a/builtin/grep.c
> +++ b/builtin/grep.c
> @@ -490,7 +490,7 @@ static void compile_submodule_options(const struct grep_opt *opt,
>  	case GREP_PATTERN_TYPE_FIXED:
>  		argv_array_push(&submodule_options, "-F");
>  		break;
> -	case GREP_PATTERN_TYPE_PCRE:
> +	case GREP_PATTERN_TYPE_PCRE1:
>  		argv_array_push(&submodule_options, "-P");
>  		break;

Hmm. This isn't a problem yet, but wouldn't this need to pass some pcre1-specific option instead of just "-P"?

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.