Re: [PATCH 2/3] column: allow for custom printf

From: Duy Nguyen <pclouds@gmail.com>
Date: Apr 10, 2017, 11:13 UTC
Message-ID: <20170410111318.GA23601@ash>
In-Reply-To: <20170330014238.30032-3-sbeller@google.com>

On Wed, Mar 29, 2017 at 06:42:37PM -0700, Stefan Beller wrote:

Show 11 quoted lines

> diff --git a/column.h b/column.h
> index 0a61917fa7..c44a1525a9 100644
> --- a/column.h
> +++ b/column.h
> @@ -24,6 +24,9 @@ struct column_options {
>  	int padding;
>  	const char *indent;
>  	const char *nl;
> +
> +	/* when non-NULL, use this printing function, fallback to printf */
> +	int (*_printf)(const char *__format, ...);

This function should take 'struct column_options *' as the first argument so a future implementation have full information. Yes we need to add a couple more lines for just wrapping plain printf, but I think it's worth it.

Show 6 quoted lines

>  };
>  
>  struct option;
> -- 
> 2.12.2.511.g2abb8caf66
>