git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 0/8] refactor the filter process code into a reusable module

From
Ben Peart <peartben@gmail.com>
Date
Apr 7, 2017, 12:03 UTC
Message-ID
<20170407120354.17736-1-benpeart@microsoft.com>

Hopefully final spin. Updates patch 6 to rename additional instances of "filter" in comment and error messages.

Refactor the filter.<driver>.process code into a separate sub-process module that can be used to reduce the cost of starting up a sub-process for multiple commands. It does this by keeping the external process running and processing all commands by communicating over standard input and standard output using the packet format (pkt-line) based protocol. Full documentation is in Documentation/technical/api-sub-process.txt.

This code is refactored from:
	Commit edcc85814c ("convert: add filter.<driver>.process option", 2016-10-16)
	keeps the external process running and processes all commands
Ben Peart (8):
  pkt-line: add packet_read_line_gently()
  convert: move packet_write_list() into pkt-line as packet_writel()
  convert: Split start_multi_file_filter into two separate functions
  convert: Separate generic structures and variables from the filter
    specific ones
  convert: Update generic functions to only use generic data structures
  convert: rename reusable sub-process functions
  sub-process: move sub-process functions into separate files
  convert: Update subprocess_read_status to not die on EOF
 Documentation/technical/api-sub-process.txt |  54 ++++++++++
 Makefile                                    |   1 +
 convert.c                                   | 159 +++++-----------------------
 pkt-line.c                                  |  31 ++++++
 pkt-line.h                                  |  11 ++
 sub-process.c                               | 120 +++++++++++++++++++++
 sub-process.h                               |  46 ++++++++
 7 files changed, 292 insertions(+), 130 deletions(-)
 create mode 100644 Documentation/technical/api-sub-process.txt
 create mode 100644 sub-process.c
 create mode 100644 sub-process.h
-- 
2.12.0.windows.1.31.g1548525701.dirty
Next: Ben Peart
Message 1 of 27 in “refactor the filter process code into a reusable module”
  1. 0/8 refactor the filter process code into a reusable moduleBen Peart, Apr 7, 2017
  2. 1/8 pkt-line: add packet_read_line_gently()Ben Peart, Apr 7, 2017
  3. Lars SchneiderApr 9, 2017
  4. 2/8 convert: move packet_write_list() into pkt-line as packet_writel()Ben Peart, Apr 7, 2017
  5. Lars SchneiderApr 9, 2017
  6. 3/8 convert: Split start_multi_file_filter into two separate functionsBen Peart, Apr 7, 2017
  7. Lars SchneiderApr 9, 2017
  8. Jeff KingApr 11, 2017
  9. Lars SchneiderApr 11, 2017
  10. Jeff KingApr 11, 2017
  11. Lars SchneiderApr 11, 2017
  12. Jeff KingApr 11, 2017
  13. Ben PeartApr 20, 2017
  14. 6/8 convert: rename reusable sub-process functionsBen Peart, Apr 7, 2017
  15. Lars SchneiderApr 10, 2017
  16. 7/8 sub-process: move sub-process functions into separate filesBen Peart, Apr 7, 2017
  17. Lars SchneiderApr 10, 2017
  18. 8/8 convert: Update subprocess_read_status to not die on EOFBen Peart, Apr 7, 2017
  19. Lars SchneiderApr 10, 2017
  20. 4/8 convert: Separate generic structures and variables from the filter specific onesBen Peart, Apr 7, 2017
  21. Lars SchneiderApr 10, 2017
  22. Junio C HamanoApr 17, 2017
  23. Ben PeartApr 18, 2017
  24. Junio C HamanoApr 19, 2017
  25. Ben PeartApr 20, 2017
  26. 5/8 convert: Update generic functions to only use generic data structuresBen Peart, Apr 7, 2017
  27. Lars SchneiderApr 10, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.