git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-read-cache: setup git dir

From
Jeff King <peff@peff.net>
Date
Apr 7, 2017, 05:22 UTC
Message-ID
<20170407052255.vc6ch633zcdiplgy@sigill.intra.peff.net>
In-Reply-To
<020feb89-be3e-1261-d9b5-cad7c38ef2f0@web.de>
On Thu, Apr 06, 2017 at 10:41:41PM +0200, René Scharfe wrote:
Show 5 quoted lines
> b1ef400e (setup_git_env: avoid blind fall-back to ".git") made programs
> that tried to access a repository without initializing properly die with
> a diagnostic message.  One offender is test-read-cache, which is used in
> p0002.  Fix it by calling setup_git_directory() before accessing the
> index.

Right, makes sense. I wondered why we didn't notice this before, but it's because it's _only_ called from the perf suite.

-Peff
Previous: René Scharfe
Message 2 of 2 in “test-read-cache: setup git dir”
  1. test-read-cache: setup git dirRené Scharfe, Apr 6, 2017
  2. Jeff KingApr 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.