git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 2/4] fsck: force core.checksumindex=1

From
Jeff King <peff@peff.net>
Date
Apr 4, 2017, 20:18 UTC
Message-ID
<20170404201826.j6yczm6hvksasj4m@sigill.intra.peff.net>
In-Reply-To
<9abad913-66a6-f537-af77-8878c428b192@jeffhostetler.com>
On Tue, Apr 04, 2017 at 09:13:33AM -0400, Jeff Hostetler wrote:
Show 6 quoted lines
> > But yeah, another way to resolve this is to get rid of the config
> > option altogether, or document in git-config.txt that
> > core.checksumIndex is obeyed by everything except git-fsck.
> 
> If there's no objections then, I'll just remove the config
> setting and keep the force_ global for fsck.

That makes the most sense to me. It doesn't fill the "remain careful by default, and we can flip the config later" criterion that Junio set out. But I really just don't think "careful" here is buying us anything.

-Peff
Previous: Jeff HostetlerNext: git@jeffhostetler.com
Message 10 of 11 in “read-cache: call verify_hdr() in a background thread”
  1. 0/4 read-cache: call verify_hdr() in a background threadgit@jeffhostetler.com, Apr 3, 2017
  2. 1/4 read-cache: core.checksumindexgit@jeffhostetler.com, Apr 3, 2017
  3. 4/4 p0002-read-cache: test core.checksumindexgit@jeffhostetler.com, Apr 3, 2017
  4. 2/4 fsck: force core.checksumindex=1git@jeffhostetler.com, Apr 3, 2017
  5. Ævar Arnfjörð BjarmasonApr 3, 2017
  6. Jeff KingApr 4, 2017
  7. Ævar Arnfjörð BjarmasonApr 4, 2017
  8. Jeff KingApr 4, 2017
  9. Jeff HostetlerApr 4, 2017
  10. Jeff KingApr 4, 2017
  11. 3/4 t1450-fsck: test core.checksumindexgit@jeffhostetler.com, Apr 3, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.