Re: ttk error when starting git gui

From: Konstantin Khomoutov <kostix+git@007spb.ru>
Date: Mar 31, 2017, 07:33 UTC
Message-ID: <20170331103330.5d7c414b6a0273cefb8508f2@domain007.com>
In-Reply-To: <916067befdc828e5d33dd3c1817989e7.squirrel@mail.jessiehernandez.com>

On Fri, 31 Mar 2017 08:44:27 +0200 "Jessie Hernandez" <git@jessiehernandez.com> wrote:

[...]

Show 21 quoted lines

> I also got this problem when I wanted to build and run git 2.10.x.
> I have added the following change to git-gui/git-gui.sh
> 
> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index 5bc21b878..5ce59ef94 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -894,7 +894,7 @@ set default_config(gui.fontui) [font configure
> font_ui] set default_config(gui.fontdiff) [font configure font_diff]
>  # TODO: this option should be added to the git-config documentation
>  set default_config(gui.maxfilesdisplayed) 5000
> -set default_config(gui.usettk) 1
> +set default_config(gui.usettk) 0
>  set default_config(gui.warndetachedcommit) 1
>  set default_config(gui.tabsize) 8
>  set font_descs {
> 
> 
> If you guys want I can submit it as a patch.
> But i assume that 'fixing' this by disabling the feature is not really
> what we want.

It's possible to have ttk with 8.5 as well (say, here on Debian 8.5 ships with ttk enabled).

A proper patch would be

-set default_config(gui.usettk) 1 +set default_config(gui.usettk) [namespace exists ::ttk]

Could you please test it on your system?