Re: Issue with 2.11.0 and GIT_EXEC_PATH with multiple entries

From: Jeff King <peff@peff.net>
Date: Mar 30, 2017, 23:32 UTC
Message-ID: <20170330233228.dfv5mxnwlppghmua@sigill.intra.peff.net>
In-Reply-To: <CAJF7t-cAtR9yp2184pUsw+w3mf-SSMW4FUY27N8+f=6u7qjx3g@mail.gmail.com>

On Thu, Mar 30, 2017 at 04:00:41PM -0700, Nate Mueller wrote:

> Really?  My config has been set this way for years and it's never
> caused problems before.  I have subcommands in both of those
> directories and all work.

Really. It did happen to work most of the time before (because most uses involved just appending it to $PATH). But it was never intended to work with multiple paths. The:

  . "$(git --exec-path)/git-sh-whatever"

advice has been advertised in the documentation for years. E.g., see bd870878f (Documentation: don't assume git-sh-setup and git-parse-remote are in PATH, 2008-06-29). So even if we wanted to relax the rules in our scripts, it seems like a potential hazard for 3rd party scripts.

The recommended way is to just put your ~/.git-exec into your $PATH.

-Peff