git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] entry.c: submodule recursing: respect force flag correctly

From
Stefan Beller <sbeller@google.com>
Date
Mar 29, 2017, 18:37 UTC
Message-ID
<20170329183743.27506-1-sbeller@google.com>

In case of a non-forced worktree update, the submodule movement is tested in a dry run first, such that it doesn't matter if the actual update is done via the force flag. However for correctness, we want to give the flag is specified by the user.

Signed-off-by: Stefan Beller <sbeller@google.com>
---
 entry.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/entry.c b/entry.c
index d2b512da90..645121f828 100644
--- a/entry.c
+++ b/entry.c
@@ -287,7 +287,7 @@ int checkout_entry(struct cache_entry *ce,
 			} else
 				return submodule_move_head(ce->name,
 					"HEAD", oid_to_hex(&ce->oid),
-					SUBMODULE_MOVE_HEAD_FORCE);
+					state->force ? SUBMODULE_MOVE_HEAD_FORCE : 0);
 		}
 
 		if (!changed)
-- 
2.12.0.rc1.52.g2de7d24de9.dirty
Next: Stefan Beller
Message 1 of 8 in “entry.c: submodule recursing: respect force flag correctly”
  1. 1/2 entry.c: submodule recursing: respect force flag correctlyStefan Beller, Mar 29, 2017
  2. 2/2 unpack-trees.c: align submodule error message to the other error messagesStefan Beller, Mar 29, 2017
  3. Jonathan NiederMar 29, 2017
  4. Junio C HamanoMar 29, 2017
  5. unpack-trees.c: align submodule error message to the other error messagesStefan Beller, Mar 29, 2017
  6. Junio C HamanoMar 29, 2017
  7. Jonathan NiederMar 29, 2017
  8. Junio C HamanoMar 29, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.