git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 2/8] convert: Update convert to use new packet_writel() function

From
Ben Peart <peartben@gmail.com>
Date
Mar 29, 2017, 15:53 UTC
Message-ID
<20170329155330.12860-3-benpeart@microsoft.com>
In-Reply-To
<20170329155330.12860-1-benpeart@microsoft.com>

convert.c had it's own packet_write_list() function that can now be replaced with the new packet_writel() function from pkt-line.

Signed-off-by: Ben Peart <benpeart@microsoft.com>
---
 convert.c | 23 ++---------------------
 1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/convert.c b/convert.c
index 8d652bf27c..793c29ebfd 100644
--- a/convert.c
+++ b/convert.c
@@ -521,25 +521,6 @@ static struct cmd2process *find_multi_file_filter_entry(struct hashmap *hashmap,
 	return hashmap_get(hashmap, &key, NULL);
 }
 
-static int packet_write_list(int fd, const char *line, ...)
-{
-	va_list args;
-	int err;
-	va_start(args, line);
-	for (;;) {
-		if (!line)
-			break;
-		if (strlen(line) > LARGE_PACKET_DATA_MAX)
-			return -1;
-		err = packet_write_fmt_gently(fd, "%s\n", line);
-		if (err)
-			return err;
-		line = va_arg(args, const char*);
-	}
-	va_end(args);
-	return packet_flush_gently(fd);
-}
-
 static void read_multi_file_filter_status(int fd, struct strbuf *status)
 {
 	struct strbuf **pair;
@@ -616,7 +597,7 @@ static struct cmd2process *start_multi_file_filter(struct hashmap *hashmap, cons
 
 	sigchain_push(SIGPIPE, SIG_IGN);
 
-	err = packet_write_list(process->in, "git-filter-client", "version=2", NULL);
+	err = packet_writel(process->in, "git-filter-client", "version=2", NULL);
 	if (err)
 		goto done;
 
@@ -632,7 +613,7 @@ static struct cmd2process *start_multi_file_filter(struct hashmap *hashmap, cons
 	if (err)
 		goto done;
 
-	err = packet_write_list(process->in, "capability=clean", "capability=smudge", NULL);
+	err = packet_writel(process->in, "capability=clean", "capability=smudge", NULL);
 
 	for (;;) {
 		cap_buf = packet_read_line(process->out, NULL);
-- 
2.12.1.gvfs.1.18.ge47db72
Previous: Ben PeartNext: Ben Peart
Message 2 of 13 in “refactor the filter process code into a reusable module”
  1. 0/8 refactor the filter process code into a reusable moduleBen Peart, Mar 29, 2017
  2. 2/8 convert: Update convert to use new packet_writel() functionBen Peart, Mar 29, 2017
  3. 1/8 pkt-line: add packet_writel() and packet_read_line_gently()Ben Peart, Mar 29, 2017
  4. 3/8 convert: Split start_multi_file_filter into two separate functionsBen Peart, Mar 29, 2017
  5. 6/8 convert: rename reusable sub-process functionsBen Peart, Mar 29, 2017
  6. 7/8 sub-process: move sub-process functions into separate filesBen Peart, Mar 29, 2017
  7. Junio C HamanoMar 29, 2017
  8. Ben PeartMar 30, 2017
  9. 8/8 convert: Update subprocess_read_status to not die on EOFBen Peart, Mar 29, 2017
  10. 4/8 convert: Separate generic structures and variables from the filter specific onesBen Peart, Mar 29, 2017
  11. 5/8 convert: Update generic functions to only use generic data structuresBen Peart, Mar 29, 2017
  12. Junio C HamanoMar 29, 2017
  13. Ben PeartMar 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.