Re: [PATCH v2 1/2] read-cache: skip index SHA verification
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 27, 2017, 23:32 UTC
- Message-ID
- <20170327233210.GO31294@aiede.mtv.corp.google.com>
- In-Reply-To
- <20170327224408.2bzh5vfa6deni6fm@sigill.intra.peff.net>
Jeff King wrote:
Show 14 quoted lines
> Hrm, there shouldn't be any dependency of the config on the index (and > there are a handful of options which impact the index already). Did you > try it and run into problems? > > In general, I'd much rather see us either: > > 1. Rip the code out entirely if it is not meant to be configurable, > and cannot be triggered by the actual git binary. > > or > > 2. Make it configurable, even if most people wouldn't use it. And then > have a test to exercise it using a git command (unlike the one-off > test helper, which isn't run at all).
Agreed with this, leaning toward (1).
If "git fsck" verifies the .git/index file then I don't see any need for other commands to.
Thanks and hope that helps, Jonathan