Re: [PATCH 1/7] submodule.c: use argv_array in is_submodule_modified
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Mar 24, 2017, 22:25 UTC
- Message-ID
- <20170324222557.GF31294@aiede.mtv.corp.google.com>
- In-Reply-To
- <20170324182902.19280-2-sbeller@google.com>
Stefan Beller wrote:
> struct argv_array is easier to use and maintain
Missing '.' at end of sentence.
> Signed-off-by: Stefan Beller <sbeller@google.com> > --- > submodule.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-)
With or without that tweak, I still like this as much as last time. :) Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.