git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: fix missing newline

From
BWBrandon Williams <bmwill@google.com>
Date
Mar 23, 2017, 17:47 UTC
Message-ID
<20170323174716.GA111250@google.com>
In-Reply-To
<alpine.DEB.2.20.1703231839570.3767@virtualbox>
On 03/23, Johannes Schindelin wrote:
Show 13 quoted lines
> Hi Brandon,
> 
> On Thu, 23 Mar 2017, Brandon Williams wrote:
> 
> > When using rebase --interactive where one of the lines is marked as
> > 'edit' this is the resulting output:
> > 
> >     Stopped at ec3b9c4...  stuffYou can amend the commit now, with
> 
> Ugh, I should have caught this. The warning() call implicitly adds a
> newline, the fprintf() doesn't.
> 
> Patch is obviously good.

All good. If we're keeping score for finding each others bugs, I still think you're winning :)

-- 
Brandon Williams
Previous: Johannes SchindelinNext: Jeff King
Message 3 of 9 in “sequencer: fix missing newline”
  1. sequencer: fix missing newlineBrandon Williams, Mar 23, 2017
  2. Johannes SchindelinMar 23, 2017
  3. Brandon WilliamsMar 23, 2017
  4. Jeff KingMar 23, 2017
  5. Jeff KingMar 23, 2017
  6. Brandon WilliamsMar 23, 2017
  7. Junio C HamanoMar 23, 2017
  8. Jonathan NiederMar 23, 2017
  9. Junio C HamanoMar 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.