git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GSoC][PATCH v6 3/3] credential-cache: add tests for XDG functionality

From
Devin Lehmacher <lehmacdj@gmail.com>
Date
Mar 17, 2017, 12:36 UTC
Message-ID
<20170317123634.10863-3-lehmacdj@gmail.com>
In-Reply-To
<20170317123634.10863-1-lehmacdj@gmail.com>
Signed-off-by: Devin Lehmacher <lehmacdj@gmail.com>
---
 t/t0301-credential-cache.sh | 93 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 93 insertions(+)
diff --git a/t/t0301-credential-cache.sh b/t/t0301-credential-cache.sh
index 82c841121..fd92533ac 100755
--- a/t/t0301-credential-cache.sh
+++ b/t/t0301-credential-cache.sh
@@ -12,7 +12,100 @@ test -z "$NO_UNIX_SOCKETS" || {
 # don't leave a stale daemon running
 trap 'code=$?; git credential-cache exit; (exit $code); die' EXIT
 
+# test that the daemon works with no special setup
 helper_test cache
+
+test_expect_success 'socket defaults to ~/.cache/git/credential/socket' '
+	test_when_finished "
+		git credential-cache exit &&
+		rmdir -p .cache/git/credential/
+	" &&
+	test_path_is_missing "$HOME/.git-credential-cache" &&
+	test -S "$HOME/.cache/git/credential/socket"
+'
+
+XDG_CACHE_HOME="$HOME/xdg"
+export XDG_CACHE_HOME
+# test behavior when XDG_CACHE_HOME is set
+helper_test cache
+
+test_expect_success "use custom XDG_CACHE_HOME if set and default sockets are not created" '
+	test_when_finished "git credential-cache exit" &&
+	test -S "$XDG_CACHE_HOME/git/credential/socket" &&
+	test_path_is_missing "$HOME/.git-credential-cache/socket" &&
+	test_path_is_missing "$HOME/.cache/git/credential/socket"
+'
+unset XDG_CACHE_HOME
+
+test_expect_success 'credential-cache --socket option overrides default location' '
+	test_when_finished "
+		git credential-cache exit --socket \"\$HOME/dir/socket\" &&
+		rmdir \"\$HOME/dir\"
+	" &&
+	check approve "cache --socket \"\$HOME/dir/socket\"" <<-\EOF &&
+	protocol=https
+	host=example.com
+	username=store-user
+	password=store-pass
+	EOF
+	test -S "$HOME/dir/socket"
+'
+
+test_expect_success "use custom XDG_CACHE_HOME even if xdg socket exists" '
+	test_when_finished "
+		git credential-cache exit &&
+		sane_unset XDG_CACHE_HOME
+	" &&
+	check approve cache <<-\EOF &&
+	protocol=https
+	host=example.com
+	username=store-user
+	password=store-pass
+	EOF
+	test -S "$HOME/.cache/git/credential/socket" &&
+	XDG_CACHE_HOME="$HOME/xdg" &&
+	export XDG_CACHE_HOME &&
+	check approve cache <<-\EOF &&
+	protocol=https
+	host=example.com
+	username=store-user
+	password=store-pass
+	EOF
+	test -S "$XDG_CACHE_HOME/git/credential/socket"
+'
+
+test_expect_success 'use user socket if user directory exists' '
+	test_when_finished "
+		git credential-cache exit &&
+		rmdir \"\$HOME/.git-credential-cache/\"
+	" &&
+	mkdir -p -m 700 "$HOME/.git-credential-cache/" &&
+	check approve cache <<-\EOF &&
+	protocol=https
+	host=example.com
+	username=store-user
+	password=store-pass
+	EOF
+	test -S "$HOME/.git-credential-cache/socket"
+'
+
+test_expect_success SYMLINKS 'use user socket if user directory is a symlink to a directory' '
+	test_when_finished "
+		git credential-cache exit &&
+		rmdir \"\$HOME/dir/\" &&
+		rm \"\$HOME/.git-credential-cache\"
+	" &&
+	mkdir -p -m 700 "$HOME/dir/" &&
+	ln -s "$HOME/dir" "$HOME/.git-credential-cache" &&
+	check approve cache <<-\EOF &&
+	protocol=https
+	host=example.com
+	username=store-user
+	password=store-pass
+	EOF
+	test -S "$HOME/.git-credential-cache/socket"
+'
+
 helper_test_timeout cache --timeout=1
 
 # we can't rely on our "trap" above working after test_done,
-- 
2.11.0
Previous: Jeff KingNext: Jeff King
Message 34 of 54 in “Move ~/.git-credential-cache to ~/.cache/git”
  1. Devin LehmacherMar 13, 2017
  2. [GSoC][PATCH 1/3] path.c: Add xdg_cache_home to get paths under XDG_CACHE_HOMEDevin Lehmacher, Mar 13, 2017
  3. Jeff KingMar 13, 2017
  4. Devin LehmacherMar 13, 2017
  5. [GSoC][PATCH 3/3] Update documentation to reflect new socket locationDevin Lehmacher, Mar 13, 2017
  6. Junio C HamanoMar 13, 2017
  7. [GSoC][PATCH v2 2/2] credential-cache: use XDG_CACHE_HOME for socketDevin Lehmacher, Mar 13, 2017
  8. [GSoC][PATCH v2 1/2] path.c: add xdg_cache_homeDevin Lehmacher, Mar 13, 2017
  9. [GSoC][PATCH v2 2/2] credential-cache: use XDG_CACHE_HOME for socketDevin Lehmacher, Mar 13, 2017
  10. Junio C HamanoMar 13, 2017
  11. [GSoC][PATCH/RFC v3 0/3] Fix commit messages, check if socket is socketDevin Lehmacher, Mar 14, 2017
  12. [GSoC][PATCH/RFC v3 3/3] credential-cache: only use user_socket if a socketDevin Lehmacher, Mar 14, 2017
  13. Devin LehmacherMar 14, 2017
  14. Brandon WilliamsMar 14, 2017
  15. Devin LehmacherMar 14, 2017
  16. Brandon WilliamsMar 14, 2017
  17. Junio C HamanoMar 14, 2017
  18. Junio C HamanoMar 14, 2017
  19. Devin LehmacherMar 14, 2017
  20. [GSoC][PATCH v4 0/4] Moving credential-cache socket to xdg pathDevin Lehmacher, Mar 16, 2017
  21. [GSoC][PATCH v4 1/4] path.c: add xdg_cache_homeDevin Lehmacher, Mar 16, 2017
  22. [GSoC][PATCH v4 4/4] credential-cache: add tests for XDG functionalityDevin Lehmacher, Mar 16, 2017
  23. Junio C HamanoMar 16, 2017
  24. Jeff KingMar 16, 2017
  25. [GSoC][PATCH v5 1/3] path.c: add xdg_cache_homeDevin Lehmacher, Mar 17, 2017
  26. [GSoC][PATCH v5 2/3] credential-cache: use XDG_CACHE_HOME for socketDevin Lehmacher, Mar 17, 2017
  27. Ramsay JonesMar 17, 2017
  28. Devin LehmacherMar 17, 2017
  29. [GSoC][PATCH v5 3/3] credential-cache: add tests for XDG functionalityDevin Lehmacher, Mar 17, 2017
  30. Junio C HamanoMar 17, 2017
  31. [GSoC][PATCH v6 1/3] path.c: add xdg_cache_homeDevin Lehmacher, Mar 17, 2017
  32. [GSoC][PATCH v6 2/3] credential-cache: use XDG_CACHE_HOME for socketDevin Lehmacher, Mar 17, 2017
  33. Jeff KingMar 17, 2017
  34. [GSoC][PATCH v6 3/3] credential-cache: add tests for XDG functionalityDevin Lehmacher, Mar 17, 2017
  35. Jeff KingMar 17, 2017
  36. Jeff KingMar 17, 2017
  37. [GSoC][PATCH v4 2/4] dir: add directory_existsDevin Lehmacher, Mar 16, 2017
  38. Junio C HamanoMar 16, 2017
  39. Junio C HamanoMar 16, 2017
  40. [GSoC][PATCH v4 3/4] credential-cache: use XDG_CACHE_HOME for socketDevin Lehmacher, Mar 16, 2017
  41. Junio C HamanoMar 16, 2017
  42. Jeff KingMar 16, 2017
  43. [GSoC][PATCH/RFC v3 2/3] credential-cache: use XDG_CACHE_HOME for socketDevin Lehmacher, Mar 14, 2017
  44. Junio C HamanoMar 14, 2017
  45. [GSoC][PATCH/RFC v3 1/3] path.c: add xdg_cache_homeDevin Lehmacher, Mar 14, 2017
  46. Junio C HamanoMar 13, 2017
  47. [GSoC][PATCH 2/3] credential-cache.c: Make git use XDG_CACHE_HOME for credentialsDevin Lehmacher, Mar 13, 2017
  48. Junio C HamanoMar 13, 2017
  49. Jeff KingMar 13, 2017
  50. Junio C HamanoMar 13, 2017
  51. Devin LehmacherMar 13, 2017
  52. Devin LehmacherMar 13, 2017
  53. Junio C HamanoMar 13, 2017
  54. Jeff KingMar 13, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.