Re: [RFC][PATCH] index-pack: add testcases found using AFL

From: Jeff King <peff@peff.net>
Date: Mar 12, 2017, 12:24 UTC
Message-ID: <20170312122458.5iyypzfbpl6kblkn@sigill.intra.peff.net>
In-Reply-To: <3a09226f-6749-6956-6fb9-265383cd4d66@oracle.com>

On Fri, Mar 10, 2017 at 10:18:23PM +0100, Vegard Nossum wrote:

Show 13 quoted lines

> On 10/03/2017 20:42, Jeff King wrote:
> > > > That's something I guess, but I'm not enthused by the idea of just
> > > > dumping a bunch of binary test cases that nobody, not even the author,
> > > > understands.
> [...]
> 
> > My real concern is that this is the tip of the ice berg. So we increased
> > coverage in one program by a few percent. But wouldn't this procedure be
> > applicable to lots of _other_ parts of Git, too?
> 
> I think that index-pack is in a special position given its role as the
> verifier for packs received over the network, which you also wrote here:
> https://www.spinics.net/lists/git/msg265118.html

That's true. If we take that attitude, my "slippery slope" concerns go away.

-Peff