git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 GSoC RFC] diff: allow "-" as a short-hand for "last branch"

From
Siddharth Kannan <kannan.siddharth12@gmail.com>
Date
Mar 10, 2017, 04:59 UTC
Message-ID
<20170310045903.GA2417@instance-1.c.mfqp-source.internal>

Hey, I have already worked on this, and I made the change inside sha1_name.c.

The final version of my patch is here[1].
Show 8 quoted lines
> Handling the dash in sha1_name:get_sha1_basic is not an issue but
> git
> was designed with the dash in mind for options not for this weird
> short-hand so as long as there's no decision made that git should
> actually have this short-hand everywhere it does not seem like a
> good
> idea to change anything in there because it would probably have
> unwanted side-effects.
Actually, this was discussed even when I was working on this patch.
I said [2]
Show 5 quoted lines
> Making a change in sha1_name.c will touch a lot of commands
> (setup_revisions is called from everywhere in the codebase), so, I
> am
> still trying to figure out how to do this such that the rest of the
> codepath remains unchanged.
Matthieu replied to this [3]
Show 5 quoted lines
> I don't have strong opinion on this: I tend to favor consistency and
> supporting "-" everywhere goes in this direction, but I think the
> downsides should be considered too. A large part of the exercice
> here
> is to write a good commit message!

From the discussion over the different versions of my patch, I get the feeling that enabling this shorthand for all the commands is the direction that git wants to move in.

Sorry about the time you spent on this patch.

[1]: http://public-inbox.org/git/1488007487-12965-1-git-send-email-kannan.siddharth12@gmail.com/ [2]: https://public-inbox.org/git/20170207191450.GA5569@ubuntu-512mb-blr1-01.localdomain/ [3]: https://public-inbox.org/git/vpqh944eof7.fsf@anie.imag.fr/

Thanks, Siddharth.

P.S. This message was sent _before_ 1cmCXH-0000ND-9K@crossperf.com but I didn't CC The mailing list in that message. I am sending it with the mailing list cc-ed to ensure that the conversation makes sense.

Message 1 of 1 in “diff: allow "-" as a short-hand for "last branch"”
  1. diff: allow "-" as a short-hand for "last branch"Siddharth Kannan, Mar 10, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.