Re: [PATCH] http: inform about alternates-as-redirects behavior

From: Jeff King <peff@peff.net>
Date: Mar 4, 2017, 07:41 UTC
Message-ID: <20170304074140.mzgs27jp2jer4mlv@sigill.intra.peff.net>
In-Reply-To: <20170304065548.GA20734@whir>

On Sat, Mar 04, 2017 at 06:55:48AM +0000, Eric Wong wrote:

Show 15 quoted lines

> Jeff King <peff@peff.net> wrote:
> > The warning itself:
> > 
> > > +		warning("alternate disabled by http.followRedirects!=true: %s",
> > 
> > feels like it could use some whitespace around the "!=", but maybe
> > that's just me.
> 
> Yeah, I kinda wanted to emulate the command-line syntax.
> 
> Maybe rewording it a bit and showing how to enable it will
> make more sense:
> 
> 		warning("alternate: %s", url);
> 		warning(" may be enabled by -c http.followRedirects=true");

I kind of hoped people would look at the documentation for followRedirects before blindly enabling it. Though I guess the documentation doesn't really explain the possible security implications, so maybe it doesn't matter (and they're pretty subtle anyway).

-Peff