Re: [PATCH] Do not require Python for the git-remote-{bzr,hg} placeholder scripts
- From
Jeff King <peff@peff.net>
- Date
- Mar 3, 2017, 11:21 UTC
- Message-ID
- <20170303112104.2n3hu23sajpn2x2z@sigill.intra.peff.net>
- In-Reply-To
- <0102015a93d18443-c574aaf8-5656-49e8-8848-810e1fadc87a-000000@eu-west-1.amazonses.com>
On Fri, Mar 03, 2017 at 10:57:46AM +0000, Sebastian Schuberth wrote:
> It does not make sense for these placeholder scripts to depend on Python > just because the real scripts do. At the example of Git for Windows, we > would not even be able to see those warnings as it does not ship with > Python. So just use plain shell scripts instead.
Yeah, this seems like an obvious improvement. I think we got here because the originals issued a warning but kept working, and then it was slowly whittled down to remove the "working" part.
At some point these can probably go away. It's been 3 years since they turned into nothing but warnings, so presumably most people have upgraded by now (I know people often go a long time on old distro-packaged versions, but the distro packagers would presumably figure this out in the meantime).
OTOH, it is not really hurting much, so I do not mind keeping them around for another 3 years (or more) just to catch any stragglers.
-Peff