[PATCH] t/perf: export variable used in other blocks
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Mar 2, 2017, 19:50 UTC
- Message-ID
- <20170302195041.1699-1-jonathantanmy@google.com>
- In-Reply-To
- <20170228221236.selqkf5wme3fvued@sigill.intra.peff.net>
In p0001, a variable was created in a test_expect_success block to be used in later test_perf blocks, but was not exported. This caused the variable to not appear in those blocks (this can be verified by writing 'test -n "$commit"' in those blocks), resulting in a slightly different invocation than what was intended. Export that variable.
Signed-off-by: Jonathan Tan <jonathantanmy@google.com> ---
Performance indeed does drop significantly with this patch. And I cannot say "at least this is more correct", because it isn't - as Peff thinks, it is indeed still not 100% accurate because of the resurfacing-object issue he mentions (I've verified this by constructing a test that fails even after this patch set).
Also, since we don't want to unify tree_ and blob_ (for the reason Peff mentioned in another e-mail), feel free to drop this patch set.
Having said that, while looking at the perf test, I noticed an issue with a non-exported variable, which is corrected in this patch.
t/perf/p0001-rev-list.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/t/perf/p0001-rev-list.sh b/t/perf/p0001-rev-list.sh index 16359d51a..ebf172401 100755 --- a/t/perf/p0001-rev-list.sh +++ b/t/perf/p0001-rev-list.sh @@ -15,7 +15,8 @@ test_perf 'rev-list --all --objects' ' ' test_expect_success 'create new unreferenced commit' ' - commit=$(git commit-tree HEAD^{tree} -p HEAD) + commit=$(git commit-tree HEAD^{tree} -p HEAD) && + test_export commit ' test_perf 'rev-list $commit --not --all' '
-- 2.12.0.rc1.440.g5b76565f74-goog