Re: [PATCH 03/18] lib-submodule-update: teach test_submodule_content the -C <dir> flag

From: Eric Wong <e@80x24.org>
Date: Mar 2, 2017, 02:11 UTC
Message-ID: <20170302021135.GA26453@starla>
In-Reply-To: <20170302004759.27852-4-sbeller@google.com>

Stefan Beller <sbeller@google.com> wrote:

>  test_submodule_content () {
> +	if test "$1" == "-C"

Use a single '=' for portability in sh. It's also a good idea to prefix variables with 'x' or some such, since "$1" could be "-n" or some other supported switch for test(1). So, something like:

	if test x"$1" = "x-C"

...or use a case statement.

On Debian systems, I use the "checkbashisms" from the "devscripts" package to find and avoid bash dependencies.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.