git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/2] gitweb tests: Change confusing "skip_all" phrasing

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Mar 1, 2017, 21:15 UTC
Message-ID
<20170301211540.4382-2-avarab@gmail.com>
In-Reply-To
<20170301211540.4382-1-avarab@gmail.com>

Change the phrasing so that instead of saying that the CGI module is unusable, we say that it's not available.

This came up on the git mailing list in <4b34e3a0-3da7-d821-2a7f-9a420ac1d3f6@gmail.com> from Jakub Narębski.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/gitweb-lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
index d5dab5a94f..59ef15efbd 100644
--- a/t/gitweb-lib.sh
+++ b/t/gitweb-lib.sh
@@ -110,7 +110,7 @@ perl -MEncode -e '$e="";decode_utf8($e, Encode::FB_CROAK)' >/dev/null 2>&1 || {
 }
 
 perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {
-	skip_all='skipping gitweb tests, CGI module unusable'
+	skip_all='skipping gitweb tests, CGI & CGI::Util & CGI::Carp modules not available'
 	test_done
 }
 
-- 
2.11.0
Previous: Ævar Arnfjörð BjarmasonNext: Junio C Hamano
Message 3 of 4 in “Minor changes to skip gitweb tests without Time::HiRes”
  1. 0/2 Minor changes to skip gitweb tests without Time::HiResÆvar Arnfjörð Bjarmason, Mar 1, 2017
  2. 2/2 gitweb tests: Skip tests when we don't have Time::HiResÆvar Arnfjörð Bjarmason, Mar 1, 2017
  3. 1/2 gitweb tests: Change confusing "skip_all" phrasingÆvar Arnfjörð Bjarmason, Mar 1, 2017
  4. Junio C HamanoMar 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.