Re: [PATCH] git svn branch fails with authenticaton failures
- From
- Eric Wong <e@80x24.org>
- Date
- Feb 23, 2017, 20:54 UTC
- Message-ID
- <20170223205452.GA29547@whir>
- In-Reply-To
- <1487731055-29153-1-git-send-email-h.shirosaki@gmail.com>
Hiroshi Shirosaki <h.shirosaki@gmail.com> wrote:
Show 14 quoted lines
> I have the following authentication failure while svn rebase and > svn dcommit works fine without authentication failures. > > $ git svn branch v7_3 > Copying https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx at r27519 > to https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/v7_3... > Can't create session: Unable to connect to a repository at URL > 'https://xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx': No more > credentials or we tried too many times. > Authentication failed at > C:\Program Files\Git\mingw64/libexec/git-core\git-svn line 1200. > > I can workaround the issue to add auth configuration to > SVN::Client->new().
Missing sign-off (see Documentation/SubmittingPatches). Not my rule, but it's unfortunately required for this project.
Also, the Subject: should be in the imperative mood, Perhaps something like:
Subject: [PATCH] git svn: fix authentication with 'branch'
I am less picky about the message body.
Show 7 quoted lines
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1175,10 +1175,10 @@ sub cmd_branch {
> ::_req_svn();
> require SVN::Client;
>
> + my ($config, $baton, $callbacks) = Git::SVN::Ra::prepare_config_once();Since we're not using it, here, you can avoid setting a variable for $callbacks more explicitly:
my ($config, $baton, undef) = Git::SVN::Ra::prepare_config_once();
Show 10 quoted lines
> my $ctx = SVN::Client->new(
> - config => SVN::Core::config_get_config(
> - $Git::SVN::Ra::config_dir
> - ),
> + auth => $baton,
> + config => $config,
> log_msg => sub {
> ${ $_[0] } = defined $_message
> ? $_message
> -- Anyways, this looks like a good change. I will accept a v2 with your sign-off and changes noted above. Thank you.