git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 00/19] object_id part 6

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 21, 2017, 23:47 UTC
Message-ID
<20170221234737.894681-1-sandals@crustytoothpaste.net>
This is another series in the continuing conversion to struct object_id.

This series converts more of the builtin directory and some of the refs code to use struct object_id. Additionally, it implements an nth_packed_object_oid function which provides a struct object_id version of the nth_packed_object function, and a parse_oid_hex function that makes parsing easier.

I'll be submitting the test I wrote as a separate patch, but I did build and test with it, so I feel confident that it works properly.

Changes from v4:
* Fix breakage in builtin/diff-tree pointed out by Peff.
Changes from v3:
* Move the parse_oid_hex patch earlier in the series.
* Use parse_oid_hex in builtin/diff-tree.c.
* Fix several warts with parse_oid_hex pointed out by Peff.
Changes from v2:
* Fix misnamed function in commit message.
* Improve parameter name of parse_oid_hex.
* Improve docstring of parse_oid_hex.
* Remove needless variable.
* Rebase on master.
Changes from v1:
* Implement parse_oid_hex and use it.
* Make nth_packed_object_oid take a variable into which to store the
  object ID.  This avoids concerns about unsafe casts.
* Rebase on master.
brian m. carlson (19):
  hex: introduce parse_oid_hex
  builtin/commit: convert to struct object_id
  builtin/diff-tree: convert to struct object_id
  builtin/describe: convert to struct object_id
  builtin/fast-export: convert to struct object_id
  builtin/fmt-merge-message: convert to struct object_id
  builtin/grep: convert to struct object_id
  builtin/branch: convert to struct object_id
  builtin/clone: convert to struct object_id
  builtin/merge: convert to struct object_id
  Convert remaining callers of resolve_refdup to object_id
  builtin/replace: convert to struct object_id
  reflog-walk: convert struct reflog_info to struct object_id
  refs: convert each_reflog_ent_fn to struct object_id
  refs: simplify parsing of reflog entries
  sha1_file: introduce an nth_packed_object_oid function
  Convert object iteration callbacks to struct object_id
  builtin/merge-base: convert to struct object_id
  wt-status: convert to struct object_id
 builtin/branch.c        |  26 +++++-----
 builtin/cat-file.c      |   8 +--
 builtin/clone.c         |  10 ++--
 builtin/commit.c        |  46 ++++++++---------
 builtin/count-objects.c |   4 +-
 builtin/describe.c      |  50 +++++++++---------
 builtin/diff-tree.c     |  61 +++++++++++-----------
 builtin/fast-export.c   |  58 ++++++++++-----------
 builtin/fmt-merge-msg.c |  70 ++++++++++++-------------
 builtin/fsck.c          |  40 +++++++--------
 builtin/grep.c          |  24 ++++-----
 builtin/merge-base.c    |  30 +++++------
 builtin/merge.c         | 134 ++++++++++++++++++++++++------------------------
 builtin/notes.c         |  18 +++----
 builtin/pack-objects.c  |   6 +--
 builtin/prune-packed.c  |   4 +-
 builtin/prune.c         |   8 +--
 builtin/receive-pack.c  |   4 +-
 builtin/reflog.c        |   2 +-
 builtin/replace.c       | 112 ++++++++++++++++++++--------------------
 cache.h                 |  19 ++++++-
 hex.c                   |   8 +++
 reachable.c             |  30 +++++------
 ref-filter.c            |   4 +-
 reflog-walk.c           |  26 +++++-----
 refs.c                  |  24 ++++-----
 refs.h                  |   2 +-
 refs/files-backend.c    |  29 ++++++-----
 revision.c              |  12 ++---
 sha1_file.c             |  27 +++++++---
 sha1_name.c             |   2 +-
 transport.c             |   4 +-
 wt-status.c             |  52 +++++++++----------
 33 files changed, 493 insertions(+), 461 deletions(-)
-- 
2.11.0
Next: brian m. carlson
Message 1 of 28 in “object_id part 6”
  1. 00/19 object_id part 6brian m. carlson, Feb 21, 2017
  2. 01/19 hex: introduce parse_oid_hexbrian m. carlson, Feb 21, 2017
  3. 02/19 builtin/commit: convert to struct object_idbrian m. carlson, Feb 21, 2017
  4. 07/19 builtin/grep: convert to struct object_idbrian m. carlson, Feb 21, 2017
  5. 04/19 builtin/describe: convert to struct object_idbrian m. carlson, Feb 21, 2017
  6. 09/19 builtin/clone: convert to struct object_idbrian m. carlson, Feb 21, 2017
  7. 06/19 builtin/fmt-merge-message: convert to struct object_idbrian m. carlson, Feb 21, 2017
  8. 03/19 builtin/diff-tree: convert to struct object_idbrian m. carlson, Feb 21, 2017
  9. Junio C HamanoFeb 22, 2017
  10. Jeff KingFeb 22, 2017
  11. Junio C HamanoFeb 22, 2017
  12. brian m. carlsonFeb 22, 2017
  13. t: add multi-parent test of diff-tree --stdinbrian m. carlson, Feb 22, 2017
  14. Junio C HamanoFeb 22, 2017
  15. Jeff KingFeb 22, 2017
  16. brian m. carlsonFeb 22, 2017
  17. 18/19 builtin/merge-base: convert to struct object_idbrian m. carlson, Feb 21, 2017
  18. 12/19 builtin/replace: convert to struct object_idbrian m. carlson, Feb 21, 2017
  19. 14/19 refs: convert each_reflog_ent_fn to struct object_idbrian m. carlson, Feb 21, 2017
  20. 19/19 wt-status: convert to struct object_idbrian m. carlson, Feb 21, 2017
  21. 13/19 reflog-walk: convert struct reflog_info to struct object_idbrian m. carlson, Feb 21, 2017
  22. 10/19 builtin/merge: convert to struct object_idbrian m. carlson, Feb 21, 2017
  23. 11/19 Convert remaining callers of resolve_refdup to object_idbrian m. carlson, Feb 21, 2017
  24. 17/19 Convert object iteration callbacks to struct object_idbrian m. carlson, Feb 21, 2017
  25. 15/19 refs: simplify parsing of reflog entriesbrian m. carlson, Feb 21, 2017
  26. 08/19 builtin/branch: convert to struct object_idbrian m. carlson, Feb 21, 2017
  27. 16/19 sha1_file: introduce an nth_packed_object_oid functionbrian m. carlson, Feb 21, 2017
  28. 05/19 builtin/fast-export: convert to struct object_idbrian m. carlson, Feb 21, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.