Re: [PATCH v4 03/19] builtin/diff-tree: convert to struct object_id

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Feb 21, 2017, 01:10 UTC
Message-ID: <20170221011058.cpx7uio6ibkvrtbv@genre.crustytoothpaste.net>
In-Reply-To: <20170221010836.nuv6uvyzatql2yyu@sigill.intra.peff.net>

On Mon, Feb 20, 2017 at 08:08:36PM -0500, Jeff King wrote:

Show 14 quoted lines

> On Tue, Feb 21, 2017 at 12:25:19AM +0000, brian m. carlson wrote:
> 
> > On Mon, Feb 20, 2017 at 03:09:02AM -0500, Jeff King wrote:
> > > It's a little disturbing that we do not seem to have even a basic test
> > > of:
> > > 
> > >   git rev-list --parents HEAD | git diff-tree --stdin
> > > 
> > > which would exercise this code.
> > 
> > I'm unsure, so I'll add a test.  The only way to know if it works is to
> > test it.
> 
> Not to spoil the ending, but I did test and it does not work. :)

Well, then I suppose I'll also end up sending out a new patch series. :)

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
+1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204