git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 07/15] refs: add refs_for_each_ref()

From
Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date
Feb 17, 2017, 14:19 UTC
Message-ID
<20170217141908.18012-8-pclouds@gmail.com>
In-Reply-To
<20170217141908.18012-1-pclouds@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 refs.c | 33 ++++++++++++++++++++++-----------
 refs.h |  1 +
 2 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/refs.c b/refs.c
index 26758b8cf..fc6cca3db 100644
--- a/refs.c
+++ b/refs.c
@@ -1170,10 +1170,9 @@ int head_ref(each_ref_fn fn, void *cb_data)
  * non-zero value, stop the iteration and return that value;
  * otherwise, return 0.
  */
-static int do_for_each_ref(const char *submodule, const char *prefix,
+static int do_for_each_ref(struct ref_store *refs, const char *prefix,
 			   each_ref_fn fn, int trim, int flags, void *cb_data)
 {
-	struct ref_store *refs = get_submodule_ref_store(submodule);
 	struct ref_iterator *iter;
 
 	if (!refs)
@@ -1185,19 +1184,26 @@ static int do_for_each_ref(const char *submodule, const char *prefix,
 	return do_for_each_ref_iterator(iter, fn, cb_data);
 }
 
+int refs_for_each_ref(struct ref_store *refs, each_ref_fn fn, void *cb_data)
+{
+	return do_for_each_ref(refs, "", fn, 0, 0, cb_data);
+}
+
 int for_each_ref(each_ref_fn fn, void *cb_data)
 {
-	return do_for_each_ref(NULL, "", fn, 0, 0, cb_data);
+	return do_for_each_ref(get_main_ref_store(), "", fn, 0, 0, cb_data);
 }
 
 int for_each_ref_submodule(const char *submodule, each_ref_fn fn, void *cb_data)
 {
-	return do_for_each_ref(submodule, "", fn, 0, 0, cb_data);
+	return do_for_each_ref(get_submodule_ref_store(submodule),
+			       "", fn, 0, 0, cb_data);
 }
 
 int for_each_ref_in(const char *prefix, each_ref_fn fn, void *cb_data)
 {
-	return do_for_each_ref(NULL, prefix, fn, strlen(prefix), 0, cb_data);
+	return do_for_each_ref(get_main_ref_store(),
+			       prefix, fn, strlen(prefix), 0, cb_data);
 }
 
 int for_each_fullref_in(const char *prefix, each_ref_fn fn, void *cb_data, unsigned int broken)
@@ -1206,19 +1212,23 @@ int for_each_fullref_in(const char *prefix, each_ref_fn fn, void *cb_data, unsig
 
 	if (broken)
 		flag = DO_FOR_EACH_INCLUDE_BROKEN;
-	return do_for_each_ref(NULL, prefix, fn, 0, flag, cb_data);
+	return do_for_each_ref(get_main_ref_store(),
+			       prefix, fn, 0, flag, cb_data);
 }
 
 int for_each_ref_in_submodule(const char *submodule, const char *prefix,
 		each_ref_fn fn, void *cb_data)
 {
-	return do_for_each_ref(submodule, prefix, fn, strlen(prefix), 0, cb_data);
+	return do_for_each_ref(get_submodule_ref_store(submodule),
+			       prefix, fn, strlen(prefix), 0, cb_data);
 }
 
 int for_each_replace_ref(each_ref_fn fn, void *cb_data)
 {
-	return do_for_each_ref(NULL, git_replace_ref_base, fn,
-			       strlen(git_replace_ref_base), 0, cb_data);
+	return do_for_each_ref(get_main_ref_store(),
+			       git_replace_ref_base, fn,
+			       strlen(git_replace_ref_base),
+			       0, cb_data);
 }
 
 int for_each_namespaced_ref(each_ref_fn fn, void *cb_data)
@@ -1226,14 +1236,15 @@ int for_each_namespaced_ref(each_ref_fn fn, void *cb_data)
 	struct strbuf buf = STRBUF_INIT;
 	int ret;
 	strbuf_addf(&buf, "%srefs/", get_git_namespace());
-	ret = do_for_each_ref(NULL, buf.buf, fn, 0, 0, cb_data);
+	ret = do_for_each_ref(get_main_ref_store(),
+			      buf.buf, fn, 0, 0, cb_data);
 	strbuf_release(&buf);
 	return ret;
 }
 
 int for_each_rawref(each_ref_fn fn, void *cb_data)
 {
-	return do_for_each_ref(NULL, "", fn, 0,
+	return do_for_each_ref(get_main_ref_store(), "", fn, 0,
 			       DO_FOR_EACH_INCLUDE_BROKEN, cb_data);
 }
 
diff --git a/refs.h b/refs.h
index 54c038e3c..8e3b4e839 100644
--- a/refs.h
+++ b/refs.h
@@ -574,5 +574,6 @@ int refs_read_ref_full(struct ref_store *refs,
 int refs_read_ref(struct ref_store *refs,
 		  const char *refname, unsigned char *sha1);
 int refs_head_ref(struct ref_store *refs, each_ref_fn fn, void *cb_data);
+int refs_for_each_ref(struct ref_store *refs, each_ref_fn fn, void *cb_data);
 
 #endif /* REFS_H */
-- 
2.11.0.157.gd943d85
Previous: Nguyễn Thái Ngọc DuyNext: Nguyễn Thái Ngọc Duy
Message 8 of 33 in “Fix git-gc losing objects in multi worktree”
  1. 00/15 Fix git-gc losing objects in multi worktreeNguyễn Thái Ngọc Duy, Feb 17, 2017
  2. 01/15 revision.h: new flag in struct rev_info wrt. worktree-related refsNguyễn Thái Ngọc Duy, Feb 17, 2017
  3. 02/15 revision.c: refactor add_index_objects_to_pending()Nguyễn Thái Ngọc Duy, Feb 17, 2017
  4. 03/15 revision.c: --indexed-objects add objects from all worktreesNguyễn Thái Ngọc Duy, Feb 17, 2017
  5. 04/15 refs: move submodule slash stripping code to get_submodule_ref_storeNguyễn Thái Ngọc Duy, Feb 17, 2017
  6. 06/15 refs: add refs_head_ref()Nguyễn Thái Ngọc Duy, Feb 17, 2017
  7. 05/15 refs: add refs_read_ref[_full]()Nguyễn Thái Ngọc Duy, Feb 17, 2017
  8. 07/15 refs: add refs_for_each_ref()Nguyễn Thái Ngọc Duy, Feb 17, 2017
  9. 08/15 refs: add a refs_for_each_in() and friendsNguyễn Thái Ngọc Duy, Feb 17, 2017
  10. 09/15 revision.c: use refs_for_each*() instead of for_each_*_submodule()Nguyễn Thái Ngọc Duy, Feb 17, 2017
  11. 10/15 refs: remove dead for_each_*_submodule()Nguyễn Thái Ngọc Duy, Feb 17, 2017
  12. 12/15 refs: add refs_for_each_reflog[_ent]()Nguyễn Thái Ngọc Duy, Feb 17, 2017
  13. 11/15 revision.c: --all adds HEAD from all worktreesNguyễn Thái Ngọc Duy, Feb 17, 2017
  14. 13/15 files-backend: make reflog iterator go through per-worktree reflogNguyễn Thái Ngọc Duy, Feb 17, 2017
  15. 14/15 revision.c: --reflog add HEAD reflog from all worktreesNguyễn Thái Ngọc Duy, Feb 17, 2017
  16. 15/15 rev-list: expose and document --single-worktreeNguyễn Thái Ngọc Duy, Feb 17, 2017
  17. Johannes SchindelinFeb 17, 2017
  18. 00/12 Fix git-gc losing objects in multi worktreeNguyễn Thái Ngọc Duy, Mar 18, 2017
  19. 03/12 revision.c: --indexed-objects add objects from all worktreesNguyễn Thái Ngọc Duy, Mar 18, 2017
  20. 04/12 refs.c: refactor get_submodule_ref_store(), share common free blockNguyễn Thái Ngọc Duy, Mar 18, 2017
  21. 01/12 revision.h: new flag in struct rev_info wrt. worktree-related refsNguyễn Thái Ngọc Duy, Mar 18, 2017
  22. 06/12 refs: add refs_head_ref()Nguyễn Thái Ngọc Duy, Mar 18, 2017
  23. 02/12 revision.c: refactor add_index_objects_to_pending()Nguyễn Thái Ngọc Duy, Mar 18, 2017
  24. 05/12 refs: move submodule slash stripping code to get_submodule_ref_storeNguyễn Thái Ngọc Duy, Mar 18, 2017
  25. 12/12 rev-list: expose and document --single-worktreeNguyễn Thái Ngọc Duy, Mar 18, 2017
  26. Junio C HamanoMar 18, 2017
  27. Duy NguyenApr 19, 2017
  28. Junio C HamanoApr 20, 2017
  29. 10/12 files-backend: make reflog iterator go through per-worktree reflogNguyễn Thái Ngọc Duy, Mar 18, 2017
  30. 09/12 revision.c: --all adds HEAD from all worktreesNguyễn Thái Ngọc Duy, Mar 18, 2017
  31. 11/12 revision.c: --reflog add HEAD reflog from all worktreesNguyễn Thái Ngọc Duy, Mar 18, 2017
  32. 08/12 refs: remove dead for_each_*_submodule()Nguyễn Thái Ngọc Duy, Mar 18, 2017
  33. 07/12 revision.c: use refs_for_each*() instead of for_each_*_submodule()Nguyễn Thái Ngọc Duy, Mar 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.