Re: Incorrect pipe for git log graph when using --name-status option

From: Jeff King <peff@peff.net>
Date: Feb 13, 2017, 21:27 UTC
Message-ID: <20170213212734.howisucqqhusbglc@sigill.intra.peff.net>
In-Reply-To: <xmqq37fhdc27.fsf@gitster.mtv.corp.google.com>

On Mon, Feb 13, 2017 at 01:18:40PM -0800, Junio C Hamano wrote:

Show 17 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > I think the problem is specifically related to the "terminator" versus
> > "separator" semantics. Try:
> >
> >   git log --graph --name-status --pretty=format:%h
> >
> > versus:
> >
> >   git log --graph --name-status --pretty=tformat:%h
> >
> > The latter works fine. The problem seems to happen with all diff
> > formats, so I think the issue is that git is not aggressive enough about
> > inserting the newline at the right spot when using separator mode.
> 
> I guess that is one of the reasons why we made --format=%h a synonym
> to --pretty=tformat:%h and not --pretty=format:%h ;-)

Yeah. I have never found "--pretty=format" to do what I want versus tformat. I wish we could just get rid of it, but I think it is likely to be used as a plumbing interface.

So I think there probably _is_ a bug in it to be fixed, but my immediate response is "don't ever use --pretty=format:".

-Peff