Re: [PATCH v3 4/5] stash: introduce new format create

From: Jeff King <peff@peff.net>
Date: Feb 6, 2017, 15:56 UTC
Message-ID: <20170206155606.xgkmhg656vuc6uki@sigill.intra.peff.net>
In-Reply-To: <20170205202642.14216-5-t.gummerer@gmail.com>

On Sun, Feb 05, 2017 at 08:26:41PM +0000, Thomas Gummerer wrote:

Show 11 quoted lines

> git stash create currently supports a positional argument for adding a
> message.  This is not quite in line with how git commands usually take
> comments (using a -m flag).
> 
> Add a new syntax for adding a message to git stash create using a -m
> flag.  This is with the goal of deprecating the old style git stash
> create with positional arguments.
> 
> This also adds a -u argument, for untracked files.  This is already used
> internally as another positional argument, but can now be used from the
> command line.

How do we tell the difference between new-style invocations, and old-style ones that look new-style? IOW, I think:

  git stash create -m works

currently treats "-m works" as the full message, and it would now become just "works".

That may be an acceptable loss for the benefit we are getting. The alternative is to make yet another verb for create, as we did with save/push). I have a feeling that hardly anybody uses "create", though, and it's mostly an implementation detail. So given the obscure nature, maybe it's an acceptable level of regression. I dunno.

But either way, it should probably be in the commit message in case somebody does have to track it down later.

-Peff