Re: [PATCH] tag: add a config option for setting --annotate by default

From: David Aguilar <davvid@gmail.com>
Date: Feb 5, 2017, 04:10 UTC
Message-ID: <20170205041059.k6amkuynvv5o4iyi@gmail.com>
In-Reply-To: <xmqqlgtm8s5k.fsf@gitster.mtv.corp.google.com>

On Fri, Feb 03, 2017 at 09:02:47PM -0800, Junio C Hamano wrote:

Show 22 quoted lines

> David Aguilar <davvid@gmail.com> writes:
> 
> > Make it easier for users to remember to annotate their tags.
> > Allow setting the default value for "--annotate" via the "tag.annotate"
> > configuration variable.
> >
> > Signed-off-by: David Aguilar <davvid@gmail.com>
> > ---
> 
> I do not care too strongly about this, but I need to point out that
> this will have fallout to tools and scripts.  E.g. if you have this
> configured and try to create a new tag in gitk, wouldn't this part
> 
> 	if {$msg != {}} {
> 	    exec git tag -a -m $msg $tag $id
> 	} else {
> 	    exec git tag $tag $id
> 	}
> 
> try to open an editor somehow to get the message even when $msg is
> an empty string?  I think the same problem already exists for the
> tag.forceSignAnnotated variable we already have added, though.

That's true. I should have put "RFC" in the subject line. Let's drop this patch unless there's others that find it useful.

How do you feel about a patch to add "git merge --signoff", for consistency with "git commit"?

The rationale is that there might be situations (evil merges, or even regular merges depending on the project) where someone might want to signoff on their merges.

-- 
David