Re: [PATCH] document behavior of empty color name

From: Jeff King <peff@peff.net>
Date: Feb 4, 2017, 00:49 UTC
Message-ID: <20170204004944.cnhy3lthcuocgltm@sigill.intra.peff.net>
In-Reply-To: <xmqqy3xnf8jm.fsf@gitster.mtv.corp.google.com>

On Fri, Feb 03, 2017 at 10:12:13AM -0800, Junio C Hamano wrote:

Show 6 quoted lines

> > Right, I think that's the correct behavior. The empty color name is a
> > real color ("none"), and you can put it in your list just like any other
> > color.
> 
> Makes me wonder if we have a non-empty string that spells the same
> "do nothing", because ...

I don't think we do. "plain" or "none" or something would work. Or I suppose "reset". That is not the same thing, but for practical purposes it probably is.

> The above is just me "wondering"; I do not think what we have needs
> further tweaks--an empty after the final comma that means "do-nothing"
> is fine, I would think.

Yeah. I think doing anything more fancy opens more questions than it answers.

-Peff