git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 3/7] Documentation: remove unneeded argument in cat-texi.perl

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Jan 21, 2017, 21:59 UTC
Message-ID
<20170121215912.246691-4-sandals@crustytoothpaste.net>
In-Reply-To
<20170121215912.246691-1-sandals@crustytoothpaste.net>

The newly-added use of the warnings pragma exposes that the $menu[0] argument to printf has long been silently ignored, since there is no format specifier for it. It doesn't appear that the argument is actually needed, either: there is no reason to insert the name of one particular documentation page anywhere in the header that's being generated.

Remove the unused argument, and since the format specification functionality is no longer needed, convert the printf to a simple print.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 Documentation/cat-texi.perl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/cat-texi.perl b/Documentation/cat-texi.perl
index 1bc84d3c7..14d2f8341 100755
--- a/Documentation/cat-texi.perl
+++ b/Documentation/cat-texi.perl
@@ -20,7 +20,7 @@ while (<STDIN>) {
 }
 close $tmp;
 
-printf '\input texinfo
+print '\input texinfo
 @setfilename gitman.info
 @documentencoding UTF-8
 @dircategory Development
@@ -31,7 +31,7 @@ printf '\input texinfo
 @top Git Manual Pages
 @documentlanguage en
 @menu
-', $menu[0];
+';
 
 for (@menu) {
 	print "* ${_}::\n";
Previous: brian m. carlsonNext: brian m. carlson
Message 2 of 9 in “Macro for Asciidoctor support”
  1. 0/7 Macro for Asciidoctor supportbrian m. carlson, Jan 21, 2017
  2. 3/7 Documentation: remove unneeded argument in cat-texi.perlbrian m. carlson, Jan 21, 2017
  3. 2/7 Documentation: modernize cat-texi.perlbrian m. carlson, Jan 21, 2017
  4. 1/7 Documentation: fix warning in cat-texi.perlbrian m. carlson, Jan 21, 2017
  5. 4/7 Documentation: sort sources for gitman.texibrian m. carlson, Jan 21, 2017
  6. 7/7 Makefile: add a knob to enable the use of Asciidoctorbrian m. carlson, Jan 21, 2017
  7. 5/7 Documentation: add XSLT to fix DocBook for Texinfobrian m. carlson, Jan 21, 2017
  8. 6/7 Documentation: move dblatex arguments into variablebrian m. carlson, Jan 21, 2017
  9. Øyvind A. HolmJan 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.